fix: web support #78
Merged
fix: web support #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for this PR. A little worried this may break interactivity on mobile with pointer events 'none'. Will test thoroughly and make any changes as necessary. I would also like to make it so that on web, screen reader enablement can be overridden. Thanks! |
Member
|
Yea, it looks like this breaks all interactivity for mobile. Let's see if we can find another solution for this. I will be merging the screen reader fix however. |
Member
|
On second thought, the fix works for Web so we will just go ahead and wrap the pointer events in a platform select 😄 |
nickdebaise
added a commit
that referenced
this pull request
Nov 2, 2025
* docs: add Korean translation (README-ko.md) and language switch links (#77) * docs: add Korean translation for README * docs: add language switch links to README and README-ko.md - Added English ↔ Korean navigation links at the top of both files - Helps users easily switch between README.md and README-ko.md * fix: web support (#78) * fix: web support * fix: fix interactivity on mobile, add param for screen reader, update docs --------- Co-authored-by: Nick DeBaise <nickdebaise@gmail.com> * feat: Add globalLimit prop to control maximum visible toasts per provider (#76) * feat: add globalLimit option to control the maximum number of toasts displayed * Use optional chaining for toastOptions.limit * fix: fix up merge conflict. Note-to-self: Do not use Github web UI for merginggit add * feat: add unit test for toast limit functionality based on globalLimit prop * fix: update toast dismissal method in tests from dismiss() to remove() for consistency --------- Co-authored-by: Nick DeBaise <nickdebaise@gmail.com> --------- Co-authored-by: Suin Kim <contact@suinkim.me> Co-authored-by: Micael Dias <me@micaeldias.dev> Co-authored-by: daeun.yang <75559282+dana-y@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68