Skip to content

Use navigation handler in onClick to view full results#18407

Merged
benjdlambert merged 2 commits intobackstage:masterfrom
ciprianna:master
Jul 10, 2023
Merged

Use navigation handler in onClick to view full results#18407
benjdlambert merged 2 commits intobackstage:masterfrom
ciprianna:master

Conversation

@ciprianna
Copy link
Copy Markdown
Contributor

@ciprianna ciprianna commented Jun 23, 2023

Hey, I just made a Pull Request!

Full results button in searchModal was not correctly navigating onClick. This switches the onClick to the correct handler function to navigate.

Fixes bug described in #18381, where clicking the link does not navigate to the full results page.

✔️ Checklist

  • [✔️ ] A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • [✔️ ] Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • [✔️ ] All your commits have a Signed-off-by line in the message. (more info)

@ciprianna
Use navigation handler in onClick to view full results
c338140 
Full results button in searchModal was not correctly navigating
onClick. This switches the onClick to the correct handler
function to navigate.

Signed-off-by: Ciprianna Engel <ciprianna.engel@wpengine.com>
@ciprianna ciprianna requested a review from a team as a code owner June 23, 2023 14:39
@github-actions github-actions bot added area:discoverability Related to the Discoverability Project Area search labels Jun 23, 2023
@backstage-goalie
Copy link
Copy Markdown
Contributor

backstage-goalie bot commented Jun 23, 2023 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-search plugins/search patch v1.3.3-next.1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 23, 2023 •
edited
Loading

Uffizzi Preview deployment-29305 was deleted.

@ciprianna
Copy link
Copy Markdown
Contributor Author

ciprianna commented Jun 23, 2023

@camilaibs - this is related to your change here. It looks like this was just a typo, but please let me know if this is different from what you were expecting.

awanlin
awanlin approved these changes Jun 23, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for running with a fix for this @ciprianna, this looks good to me 🚀

@awanlin
Copy link
Copy Markdown
Collaborator

awanlin commented Jun 23, 2023

FYI @ciprianna the E2E test failing are not related to your changes so don't worry about them for now

@ciprianna
Copy link
Copy Markdown
Contributor Author

ciprianna commented Jun 23, 2023

okay, thanks @awanlin. Was just looking into that 😅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 30, 2023

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Jun 30, 2023
@github-actions github-actions bot closed this Jul 5, 2023
@ciprianna
Copy link
Copy Markdown
Contributor Author

ciprianna commented Jul 6, 2023

re-open - I think this is good, just needs the codeowners approval.

@awanlin awanlin reopened this Jul 9, 2023
@awanlin
Copy link
Copy Markdown
Collaborator

awanlin commented Jul 9, 2023

Hi @aitherios, @soapraj, any chance you can review this? It's a fairly impactful issue as it means you can't get to the search results without some poor workarounds.

@benjdlambert just adding this to your radar as well, would be great to get into the next release!

@ciprianna re-opened this for you, sorry I lost track of it and we didn't get this pushed forward

@awanlin
Copy link
Copy Markdown
Collaborator

awanlin commented Jul 9, 2023

Sadly it looks like we might also hit some build issue that are not related to this change again :(

@github-actions github-actions bot removed the stale label Jul 9, 2023
@benjdlambert benjdlambert merged commit 4301035 into backstage:master Jul 10, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 10, 2023

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.16.0 release, scheduled for Tue, 18 Jul 2023.

@awanlin
Copy link
Copy Markdown
Collaborator

awanlin commented Jul 10, 2023

Many thanks for the contribution @ciprianna! Thanks for the reviews @tikabom and @benjdlambert 🚀

@awanlin awanlin mentioned this pull request Jul 10, 2023
Closed
2 tasks
@benjdlambert benjdlambert mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjdlambert benjdlambert benjdlambert approved these changes

@tikabom tikabom tikabom approved these changes

@awanlin awanlin awanlin approved these changes

Assignees

No one assigned

Labels

area:discoverability Related to the Discoverability Project Area

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ciprianna @awanlin @benjdlambert @tikabom