Skip to content

Airbrake backend: Support the new backend system#18598

Merged
benjdlambert merged 2 commits intobackstage:masterfrom
anicke:airbrake-new-backend
Jul 11, 2023
Merged

Airbrake backend: Support the new backend system#18598
benjdlambert merged 2 commits intobackstage:masterfrom
anicke:airbrake-new-backend

Conversation

@anicke
Copy link
Copy Markdown
Contributor

@anicke anicke commented Jul 6, 2023

Hey, I just made a Pull Request!

Added support for the new backend system for the airbrake plugin.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@anicke anicke requested review from a team and backstage-service as code owners July 6, 2023 05:20
@anicke anicke requested a review from benjdlambert July 6, 2023 05:20
@backstage-goalie
Copy link
Copy Markdown
Contributor

backstage-goalie bot commented Jul 6, 2023 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-airbrake-backend plugins/airbrake-backend patch v0.2.20-next.0
@backstage/plugin-airbrake plugins/airbrake patch v0.3.20-next.1

@anicke
Copy link
Copy Markdown
Contributor Author

anicke commented Jul 6, 2023

Ping #18301

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 6, 2023 •
edited
Loading

Uffizzi Preview deployment-30278 was deleted.

Airbrake backend: Support the new backend system
a95bb64 
Signed-off-by: Niklas Aronsson <niklasar@axis.com>
@anicke anicke force-pushed the airbrake-new-backend branch from 5bddca6 to a95bb64 Compare July 6, 2023 05:35
awanlin
awanlin requested changes Jul 8, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @anicke 🚀

The code changes look good to me just left a comment about the README

@backstage-goalie
Copy link
Copy Markdown
Contributor

backstage-goalie bot commented Jul 9, 2023

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

@anicke anicke requested a review from awanlin July 9, 2023 06:41
@anicke
Copy link
Copy Markdown
Contributor Author

anicke commented Jul 9, 2023

Made the change on my phone. Could not figure out how to sign the commit. Will fix later.

awanlin
awanlin approved these changes Jul 9, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! 🚀

Just make sure to resolve the issue with the DCO.

FYI - The build failures do not looks related and we are seeing them fail the same way for other PRs

@anicke anicke force-pushed the airbrake-new-backend branch from 6e9d571 to 14321d7 Compare July 9, 2023 19:33
@benjdlambert
Copy link
Copy Markdown
Member

benjdlambert commented Jul 10, 2023

@anicke we also need a changeset for the readme update in the airbrake plugin 🙏

@anicke
Update README.md
7b60335 
Signed-off-by: Niklas Aronsson <niklasar@axis.com>
@anicke anicke force-pushed the airbrake-new-backend branch from 14321d7 to 7b60335 Compare July 10, 2023 17:25
@anicke
Copy link
Copy Markdown
Contributor Author

anicke commented Jul 10, 2023

Changeset added!

benjdlambert
benjdlambert approved these changes Jul 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@benjdlambert benjdlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks 🎉

@benjdlambert benjdlambert merged commit 460c047 into backstage:master Jul 11, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 11, 2023

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.16.0 release, scheduled for Tue, 18 Jul 2023.

@benjdlambert benjdlambert mentioned this pull request Jul 18, 2023
Merged
@anicke anicke deleted the airbrake-new-backend branch August 8, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjdlambert benjdlambert benjdlambert approved these changes

@awanlin awanlin awanlin approved these changes

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anicke @benjdlambert @awanlin