added support to Lighthouse for new backend#18633
Merged
Rugvip merged 5 commits intobackstage:masterfrom Jul 13, 2023
jroebu14:add-support-for-new-backend-system-for-lighthouse
Merged
added support to Lighthouse for new backend#18633Rugvip merged 5 commits intobackstage:masterfrom jroebu14:add-support-for-new-backend-system-for-lighthouse
Rugvip merged 5 commits intobackstage:masterfrom
jroebu14:add-support-for-new-backend-system-for-lighthouse
Conversation
Contributor
Changed Packages
|
Contributor
|
Uffizzi Preview |
Signed-off-by: Jonathan Roebuck <jroebuck@spotify.com>
Rugvip
requested changes
Jul 12, 2023
Member
Rugvip
left a comment
Rugvip
left a comment
There was a problem hiding this comment.
Thank you, looks good! 👍
Just some minor nits
| }, | ||
| async init({ config, discovery, logger, scheduler, tokenManager }) { | ||
| const winstonLogger = loggerToWinstonLogger(logger); | ||
| const catalogClient = new CatalogClient({ discoveryApi: discovery }); |
Member
There was a problem hiding this comment.
Let's depend on the catalogServiceRef from '@backstage/plugin-catalog-node/alpha' to access this instead.
tidy up example code in README Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com> Signed-off-by: Jonathan Roebuck <jroebuck@spotify.com>
Signed-off-by: Jonathan Roebuck <jroebuck@spotify.com>
Signed-off-by: Jonathan Roebuck <jroebuck@spotify.com>
Signed-off-by: Jonathan Roebuck <jroebuck@spotify.com>
!
Contributor
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Added support for the new backend system for the Lighthouse plugin.
Fixes #18655
Original issue: #18301
✔️ Checklist
Signed-off-byline in the message. (more info)