Add backstage field to export in package.json #26524
Merged
Conversation
Contributor
Changed Packages
|
Contributor
|
Thanks for the contribution! |
77668c4 to
5807f75
Compare
exports field to Backstage metadata in package.json features field to Backstage metadata in package.json
fc48e17 to
397ab03
Compare
35e21b8 to
c6cb2d1
Compare
added 6 commits
September 16, 2024 12:32
Added a fixer step to the backstage-cli fix command that will annotate default export features to the package json backstage metadata Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
c6cb2d1 to
fd8128c
Compare
features field to Backstage metadata in package.json backstage field to export in package.json
added 2 commits
September 16, 2024 12:48
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Rugvip
reviewed
Sep 16, 2024
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Rugvip
requested changes
Sep 20, 2024
Member
Rugvip
left a comment
There was a problem hiding this comment.
Nice, I think we're about ready to ship 😎
Just a couple of minor bits
added 3 commits
September 23, 2024 09:46
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
Signed-off-by: Harrison Hogg <hhogg@spotify.com>
e97b771 to
0b2794a
Compare
Rugvip
approved these changes
Sep 23, 2024
Member
Rugvip
left a comment
There was a problem hiding this comment.
Nice, let's
! 👍
Love how slim we ended up getting this in the end 🎉
Contributor
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
5 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a step to the prepack command that will add an additional "backstage" metadata field to
exportswhich provides information on the default export of the Backstage package.The way it extracts the information is to use ts-morph which works the same way as the typescript server does for IDEs and uses the compiler to build up references and resolves types so we can avoid having to traverse the AST to look for type information.