[NFS]: Default Sticky Entity Page Layout#28950
Conversation
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
|
Thanks for the contribution! |
1a90040 to
859e79c
Compare
f8f9f13 to
848ec94
Compare
| <Grid xs={12} md={infoCards.length ? 8 : undefined} item> | ||
| <Grid container spacing={3}> | ||
| {fullCards.map((card, index) => ( | ||
| <Grid key={index} className={classes.card} xs={12} md={6} item> |
There was a problem hiding this comment.
Kinda imagining that these will always be 12, regardless of size. Maybe if you expand to widescreen we'd have some side by side, but that'd be xxxl={6}
There was a problem hiding this comment.
I used md={6} for visual backwards compatibility. Wouldn't it be a breaking change if I changed this for everyone using the default layout?
There was a problem hiding this comment.
ah, arguably not or even the other way around I'd say. Currently we're kinda switching to 3 columns instead of 2 in total, but if we keep these cards at 12 it'd be more like 1.2 + 0.8 columns :p
There was a problem hiding this comment.
In my mind, we only switch to 3 columns if people add types to the cards, but if they don't, the layout will remain 2 columns. However, I updated it to the size you suggested.
848ec94 to
d2554df
Compare
Signed-off-by: Camila Belo <camilaibs@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com> Signed-off-by: Camila Belo <camilaibs@gmail.com>
a3cd14b to
db8ff82
Compare

Hey, I just made a Pull Request!
Now the default entity page layout can be customized with cards of 3 types:
info,peekandfull.So if you want to keep the layout as it was before, you don't need to do anything. But if you want to experiment with the card types and see how they are rendered, here is an example configuring the about card to be rendered as a card of type
info:app: extensions: # Entity page cards + - entity-card:catalog/about: + config: + type: info✔️ Checklist
Signed-off-byline in the message. (more info)