Feature: [Catalog] Optionally remove entities from old EntityProviders#28971
Merged
Rugvip merged 7 commits intobackstage:masterfrom Feb 27, 2025
Merged
Conversation
…ovider Signed-off-by: Jack Palmer <jackpalmer@spotify.com>
Signed-off-by: Jack Palmer <jackpalmer@spotify.com>
github-actions
Bot
added
area:catalog
Contributor
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
Signed-off-by: Jack Palmer <jackpalmer@spotify.com>
Signed-off-by: Jack Palmer <jackpalmer@spotify.com>
UsainBloot
force-pushed
the
catalog/evict-orphaned-entity-provider
branch
from
1d84ef1 to
da04ead
Compare
2 tasks
Rugvip
reviewed
Feb 25, 2025
Signed-off-by: Jack Palmer <jackpalmer@spotify.com>
Signed-off-by: Jack Palmer <jackpalmer@spotify.com>
Rugvip
approved these changes
Feb 26, 2025
freben
reviewed
Feb 26, 2025
Member
freben
left a comment
freben
left a comment
There was a problem hiding this comment.
Yep looks great. 🙏 Agree that we could do the cleanup before connect.
Signed-off-by: Jack Palmer <jackpalmer@spotify.com>
Contributor
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
freben
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When switching between different catalog providers, entities related to that provider will remain in the catalog unless manually removed or a custom cleanup provider is created.
This change enables the ability to automatically clean up entities that belong to entity providers which are no longer configured, the next time the catalog is started.
Fixes #18067
💬 Let me know if you would like me to change some of the names of the config, variables and functions to better fit the catalog terminology.
Changes
catalog.orphanProviderStrategy: deleteto enable feature✔️ Checklist
Signed-off-byline in the message. (more info)