Merged
Conversation
github-actions
Bot
added
the
area:scaffolder
Contributor
Changed Packages
|
freben
commented
Jan 22, 2026
| portable: true, | ||
| noMtime: true, | ||
| gzip: true, | ||
| } as CreateOptions & { noMtime: boolean }, |
Member
Author
There was a problem hiding this comment.
Biggest v7 improvement is that it has native typescript support. It seems that the types indeed match our intent here - if you try to change the noMtime parameter to something invalid it does complain etc.
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
|
|
||
| // Block symlinks/hardlinks that escape the extraction directory | ||
| const entry = stat as FileStat & { type?: string; linkpath?: string }; | ||
| const entry = stat as ReadEntry; |
Member
There was a problem hiding this comment.
Does this even need a cast now?
Member
Author
There was a problem hiding this comment.
Yeah it's a bit unfortunate of an interface - the doc comment for filter says
/**
* A function that is called with `(path, stat)` when creating an archive, or
* `(path, entry)` when extracting. Return true to process the file/entry, or
* false to exclude it.
*/
filter?: (path: string, entry: Stats | ReadEntry) => boolean;and in this context we are extracting - we do need to cast.
benjdlambert
approved these changes
Jan 22, 2026
Contributor
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
This was referenced Jan 22, 2026
2 tasks
jonkoops
pushed a commit
to jonkoops/backstage
that referenced
this pull request
Apr 13, 2026
upgrade to `tar` v7
jonkoops
pushed a commit
to jonkoops/backstage
that referenced
this pull request
Apr 14, 2026
upgrade to `tar` v7
jonkoops
pushed a commit
to jonkoops/backstage
that referenced
this pull request
Apr 14, 2026
upgrade to `tar` v7
jonkoops
pushed a commit
to jonkoops/backstage
that referenced
this pull request
Apr 14, 2026
upgrade to `tar` v7
jonkoops
pushed a commit
to jonkoops/backstage
that referenced
this pull request
Apr 14, 2026
upgrade to `tar` v7
jonkoops
pushed a commit
to jonkoops/backstage
that referenced
this pull request
Apr 14, 2026
upgrade to `tar` v7
jonkoops
pushed a commit
to jonkoops/backstage
that referenced
this pull request
Apr 14, 2026
upgrade to `tar` v7 Signed-off-by: Jon Koops <jonkoops@gmail.com>
This was referenced Apr 14, 2026
jonkoops
added a commit
to jonkoops/rhdh
that referenced
this pull request
Apr 20, 2026
Upgrades @backstage/backend-defaults (0.13.2 -> 0.13.3) and @backstage/plugin-scaffolder-backend (3.0.2 -> 3.0.3) to replace the deprecated tar v6 with tar v7. Backports backstage/backstage#32471 via backstage/backstage#33904.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.