Skip to content

deps: limit @remixicon/react to < 4.9.0#34045

Merged
Rugvip merged 1 commit intomasterfrom
rugvip/limit-remix-icon-version
Apr 23, 2026
Merged

deps: limit @remixicon/react to < 4.9.0#34045
Rugvip merged 1 commit intomasterfrom
rugvip/limit-remix-icon-version

Conversation

@Rugvip
Copy link
Copy Markdown
Member

@Rugvip Rugvip commented Apr 23, 2026 •
edited
Loading

Hey, I just made a Pull Request!

RemixIcons switched from Apache 2.0 to a custom license. Until we understand more about whether the new license is compatible or not we're limiting the dependency range to the v4.8.0 version of the package, which was the last version to be released under Apache 2.0

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@Rugvip
Limit @remixicon/react to versions below 4.9.0
f635139 
The license changed in 4.9.0, so we need to cap the allowed version
range across all packages that depend on it.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
@Rugvip Rugvip marked this pull request as ready for review April 23, 2026 14:56
Copilot AI review requested due to automatic review settings April 23, 2026 14:56
@Rugvip Rugvip requested review from a team and backstage-service as code owners April 23, 2026 14:56
@backstage-goalie
Copy link
Copy Markdown
Contributor

backstage-goalie Bot commented Apr 23, 2026

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/ui packages/ui patch v0.15.0-next.0
@backstage/plugin-api-docs plugins/api-docs patch v0.14.1-next.0
@backstage/plugin-app-visualizer plugins/app-visualizer patch v0.2.4-next.0
@backstage/plugin-app plugins/app patch v0.4.6-next.0
@backstage/plugin-auth plugins/auth patch v0.1.8-next.0
@backstage/plugin-catalog-graph plugins/catalog-graph patch v0.6.4-next.0
@backstage/plugin-catalog-import plugins/catalog-import patch v0.13.13-next.0
@backstage/plugin-catalog-react plugins/catalog-react patch v2.1.5-next.0
@backstage/plugin-notifications plugins/notifications patch v0.5.17-next.0
@backstage/plugin-org plugins/org patch v0.7.4-next.0
@backstage/plugin-scaffolder plugins/scaffolder patch v1.36.3-next.0
@backstage/plugin-signals plugins/signals patch v0.0.31-next.0
@backstage/plugin-techdocs plugins/techdocs patch v1.17.6-next.0

@github-actions github-actions Bot added area:catalog Related to the Catalog Project Area area:techdocs Related to the TechDocs Project Area area:scaffolder Everything and all things related to the scaffolder project area labels Apr 23, 2026
awanlin
awanlin approved these changes Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📌

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

🎨 Visual Testing with Chromatic

@backstage-goalie backstage-goalie Bot added size:medium Medium-sized pull requests receive no change in priority for reviews. waiting-for:review The PR needs a review and will be visible in the review queue unless already assigned an owner. labels Apr 23, 2026
Copilot AI reviewed Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Rugvip Rugvip merged commit 9d7ffe5 into master Apr 23, 2026
44 checks passed
@Rugvip Rugvip deleted the rugvip/limit-remix-icon-version branch April 23, 2026 16:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.51.0 release, scheduled for Tue, 19 May 2026.

@Rugvip
Copy link
Copy Markdown
Member Author

Rugvip commented Apr 23, 2026

Followup: cncf/foundation#1380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@awanlin awanlin awanlin approved these changes

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service is a code owner

Assignees

No one assigned

Labels

area:catalog Related to the Catalog Project Area area:scaffolder Everything and all things related to the scaffolder project area area:techdocs Related to the TechDocs Project Area size:medium Medium-sized pull requests receive no change in priority for reviews. waiting-for:review The PR needs a review and will be visible in the review queue unless already assigned an owner.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rugvip @awanlin