Skip to content

feat: Annotate deployment with app config checksum #46

Merged
tumido merged 3 commits intobackstage:mainfrom
nikolaik:feat/checksum-app-config
Jan 9, 2023
Merged

feat: Annotate deployment with app config checksum #46
tumido merged 3 commits intobackstage:mainfrom
nikolaik:feat/checksum-app-config

Conversation

@nikolaik
Copy link
Copy Markdown
Contributor

@nikolaik nikolaik commented Jan 4, 2023 •
edited
Loading

This allows automatic rolling deployments on config changes like described in https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments

Augments the functionality added in #23

@nikolaik nikolaik requested a review from a team as a code owner January 4, 2023 11:37
tumido
tumido requested changes Jan 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikolaik thank you for your PR! 👍 This is a good addition and it make sense to reload on this particular value change.

Please bump the chart version at https://github.com/backstage/charts/blob/main/charts/backstage/Chart.yaml#L18 so this PR can pass CI checks.

See logs here for details: https://github.com/backstage/charts/actions/runs/3837640264/jobs/6541816680

@nikolaik
feat: Annotate deployment with app config checksum
a49f87a 
This allows automatic rolling deployments on config changes
@nikolaik nikolaik force-pushed the feat/checksum-app-config branch from d226ac0 to 1a6237c Compare January 7, 2023 15:06
@nikolaik nikolaik requested a review from tumido January 7, 2023 15:06
@nikolaik
Copy link
Copy Markdown
Contributor Author

nikolaik commented Jan 7, 2023

@nikolaik thank you for your PR! 👍 This is a good addition and it make sense to reload on this particular value change.

Please bump the chart version at https://github.com/backstage/charts/blob/main/charts/backstage/Chart.yaml#L18 so this PR can pass CI checks.

See logs here for details: https://github.com/backstage/charts/actions/runs/3837640264/jobs/6541816680

thanks, bumped now!

@ChrisJBurns
Copy link
Copy Markdown
Contributor

ChrisJBurns commented Jan 9, 2023

@nikolaik

Cheers for the above, although you'll need to bump the minor version as its added functionality rather than a bug fix 👍

@nikolaik nikolaik force-pushed the feat/checksum-app-config branch from 1a6237c to 0331070 Compare January 9, 2023 13:43
@nikolaik
Copy link
Copy Markdown
Contributor Author

nikolaik commented Jan 9, 2023

Cheers for the above, although you'll need to bump the minor version as its added functionality rather than a bug fix 👍

🤦 Fixed now

ChrisJBurns
ChrisJBurns approved these changes Jan 9, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ChrisJBurns ChrisJBurns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tumido
tumido approved these changes Jan 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tumido tumido merged commit a032117 into backstage:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tumido tumido tumido approved these changes

@ChrisJBurns ChrisJBurns ChrisJBurns approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nikolaik @ChrisJBurns @tumido