fix(quay): Quay actions template secrets update#2949
Merged
AndrienkoAleksandr merged 6 commits intobackstage:mainfrom Mar 6, 2025
Merged
fix(quay): Quay actions template secrets update#2949AndrienkoAleksandr merged 6 commits intobackstage:mainfrom
AndrienkoAleksandr merged 6 commits intobackstage:mainfrom
Conversation
Contributor
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
dzemanov
changed the title
dzemanov
changed the title
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
dzemanov
force-pushed
the
quay-actions-template-update
branch
from
ff0dcad to
ba325ef
Compare
Contributor
|
Thanks for the contribution! |
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com> This reverts commit c9b8e4b0aa20c433f2112d438cfc8f31f52ef12d. Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
dzemanov
force-pushed
the
quay-actions-template-update
branch
from
ba325ef to
8765d9d
Compare
awanlin
approved these changes
Mar 1, 2025
| '@backstage-community/plugin-scaffolder-backend-module-quay': patch | ||
| --- | ||
|
|
||
| Updated insecure `ui:widget: password` used for token field to `ui:field: Secret` |
Contributor
There was a problem hiding this comment.
These files don't ship with the plugin, I'm not sure that we actually need a changeset for this then. Going to leave that up to @karthikjeeyar though 👍
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com> This reverts commit 1e00d49.
Contributor
Author
|
/cc @CryptoRodeo |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
@backstage-community/plugin-scaffolder-backend-module-quayuses the insecure deprecatedui:widget: passwordinstead ofui:field: Secret. As a result, token can be fully seen on the screen.Before:
After:
Fixes
RHIDP-6081
✔️ Checklist
Signed-off-byline in the message. (more info)