Skip to content

chore(quay): add Quay actions to workspace#3118

Merged
04kash merged 1 commit intobackstage:mainfrom
dzemanov:quay-workspace-update
Mar 28, 2025
Merged

chore(quay): add Quay actions to workspace#3118
04kash merged 1 commit intobackstage:mainfrom
dzemanov:quay-workspace-update

Conversation

@dzemanov
Copy link
Copy Markdown
Contributor

@dzemanov dzemanov commented Mar 3, 2025

Hey, I just made a Pull Request!

  • Updates quay workspace to use @backstage-community/plugin-scaffolder-backend-module-quay

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@dzemanov dzemanov requested review from a team and karthikjeeyar as code owners March 3, 2025 08:33
@dzemanov dzemanov requested a review from awanlin March 3, 2025 08:33
@backstage-goalie
Copy link
Copy Markdown
Contributor

backstage-goalie Bot commented Mar 3, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
backend workspaces/quay/packages/backend none v0.0.0

@dzemanov dzemanov force-pushed the quay-workspace-update branch from 3d3b7a6 to 04405b1 Compare March 3, 2025 13:11
@karthikjeeyar
Copy link
Copy Markdown
Contributor

cc: @CryptoRodeo

@CryptoRodeo
Copy link
Copy Markdown
Contributor

CryptoRodeo commented Mar 13, 2025

@dzemanov LGTM, I don't see any immediate issues based on these changes. It looks like you will need to rebase though...

@CryptoRodeo
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Mar 27, 2025
@dzemanov dzemanov force-pushed the quay-workspace-update branch from 04405b1 to 471392b Compare March 28, 2025 12:38
@dzemanov
Copy link
Copy Markdown
Contributor Author

dzemanov commented Mar 28, 2025

@CryptoRodeo pardon for replying so late. I have now rebased the PR.

Should this get updated too? -> https://github.com/backstage/community-plugins/blob/main/workspaces/quay/plugins/quay/src/components/QuayRepository/QuayRepository.tsx#L32

I would say yes. Check both quay.uiUrl and quay.apiUrl and only then fallback to no link.

@CryptoRodeo
Copy link
Copy Markdown
Contributor

@dzemanov No worries

Check both quay.uiUrl and quay.apiUrl and only then fallback to no link.

Yes, that's similar to what I do here: https://github.com/backstage/community-plugins/blob/main/workspaces/quay/plugins/quay/src/api/index.ts#L76-L87

@dzemanov
Copy link
Copy Markdown
Contributor Author

Screen.Recording.2025-03-28.at.14.40.53.mov

Copy link
Copy Markdown
Contributor

@CryptoRodeo CryptoRodeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Someone else with more permissions will need to approve and merge this though, I still don't have full access ...

Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
@dzemanov dzemanov force-pushed the quay-workspace-update branch from 3f9b394 to 4508473 Compare March 28, 2025 13:58
@dzemanov
Copy link
Copy Markdown
Contributor Author

@CryptoRodeo pardon, I opened a separate PR for the other issue to keep the changes focused: #3486. Thank you for reviewing! I will ask someone to take a look.

@04kash 04kash merged commit 613bd17 into backstage:main Mar 28, 2025
12 checks passed
@dzemanov dzemanov deleted the quay-workspace-update branch May 7, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants