chore(announcements): Update to Backstage 1.38#3668
chore(announcements): Update to Backstage 1.38#3668kurtaking merged 6 commits intobackstage:mainfrom
Conversation
Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
Changed Packages
|
|
Interesting. The upgrade no longer requires importing react in all files. I'll check out the release notes and get this merged. Thanks for the contribution! |
|
Hi @GabDug and @kurtaking, I would make sure to make all the changes noted here: https://backstage.github.io/upgrade-helper/?from=1.37.0&yarnPlugin=0&to=1.38.0. This includes the changes around |
✅ absolutely - thanks for the reminder. @GabDug - do you notice anything missing from the upgrade helper? |
Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
|
@kurtaking I've just replaced the |
...ces/announcements/plugins/announcements/src/components/AnnouncementPage/AnnouncementPage.tsx
Outdated
Show resolved
Hide resolved
...uncements/plugins/announcements/src/components/EditAnnouncementPage/EditAnnouncementPage.tsx
Outdated
Show resolved
Hide resolved
...ces/announcements/plugins/announcements/src/components/AnnouncementForm/AnnouncementForm.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
Thank you for the recent contributions 🙌🏼 |
|
@vinzscam - I see you requested changes. Were those addressed? |
* chore(announcements): Update to Backstage 1.38 Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com> * chore(announcements): Remove React imports and move to react-jsx Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com> * chore: changeset Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com> * chore: new launch scripts Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com> * chore: fix React imports Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com> * chore: upgrade to Backstage 1.38.1 Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com> --------- Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com> Signed-off-by: Jarek <jaroslaw.gajewski@atos.net>
Hey 👋
"jsx": "react-jsx"=> Updating to the new CLI changes the exported types from
import { InfoCardVariants } from '@backstage/core-components/*';toimport { InfoCardVariants } from '@backstage/core-components';tsc:full:I have not updated the
yarn startcommands, but I'd be happy to do it :)✔️ Checklist
Signed-off-byline in the message. (more info)