Skip to content

chore(announcements): Update to Backstage 1.38#3668

Merged
kurtaking merged 6 commits intobackstage:mainfrom
GabDug:announcements-backstage-138
Apr 24, 2025
Merged

chore(announcements): Update to Backstage 1.38#3668
kurtaking merged 6 commits intobackstage:mainfrom
GabDug:announcements-backstage-138

Conversation

@GabDug
Copy link
Member

@GabDug GabDug commented Apr 17, 2025

Hey 👋

  • Updated workspace to Backstage 1.38
  • Updated the React imports and tsconfig to use "jsx": "react-jsx"

=> Updating to the new CLI changes the exported types from import { InfoCardVariants } from '@backstage/core-components/*'; to import { InfoCardVariants } from '@backstage/core-components';

  • This fixes an issue for consumers running tsc:full:
    node_modules/@backstage-community/plugin-announcements/dist/index.d.ts:2:47 - error TS2307: Cannot find 
    module '@backstage/core-components/*' or its corresponding type declarations.
    2 import * as _backstage_core_components__ from '@backstage/core-components/*';
                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Found 1 error in node_modules/@backstage-community/plugin-announcements/dist/index.d.ts:2
    

I have not updated the yarn start commands, but I'd be happy to do it :)

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

GabDug added 3 commits April 17, 2025 09:47
Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/announcements/packages/app none v0.0.0
backend workspaces/announcements/packages/backend none v0.0.0
@backstage-community/plugin-announcements-backend workspaces/announcements/plugins/announcements-backend patch v0.3.2
@backstage-community/plugin-announcements-common workspaces/announcements/plugins/announcements-common patch v0.3.1
@backstage-community/plugin-announcements-node workspaces/announcements/plugins/announcements-node patch v0.3.2
@backstage-community/plugin-announcements-react workspaces/announcements/plugins/announcements-react patch v0.4.2
@backstage-community/plugin-announcements workspaces/announcements/plugins/announcements patch v0.5.6
@backstage-community/plugin-search-backend-module-announcements workspaces/announcements/plugins/search-backend-module-announcements patch v0.3.2

@GabDug GabDug marked this pull request as ready for review April 17, 2025 07:58
@GabDug GabDug requested review from a team and kurtaking as code owners April 17, 2025 07:58
@GabDug GabDug requested a review from vinzscam April 17, 2025 07:58
@kurtaking
Copy link
Member

Interesting. The upgrade no longer requires importing react in all files.

I'll check out the release notes and get this merged. Thanks for the contribution!

@awanlin
Copy link
Contributor

awanlin commented Apr 17, 2025

Hi @GabDug and @kurtaking, I would make sure to make all the changes noted here: https://backstage.github.io/upgrade-helper/?from=1.37.0&yarnPlugin=0&to=1.38.0. This includes the changes around yarn start as that will be the convention people will come to expect.

@kurtaking
Copy link
Member

Hi @GabDug and @kurtaking, I would make sure to make all the changes noted here: https://backstage.github.io/upgrade-helper/?from=1.37.0&yarnPlugin=0&to=1.38.0. This includes the changes around yarn start as that will be the convention people will come to expect.

✅ absolutely - thanks for the reminder.

@GabDug - do you notice anything missing from the upgrade helper?

Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
@GabDug
Copy link
Member Author

GabDug commented Apr 17, 2025

@kurtaking I've just replaced the yarn dev script, so it seems complete.

Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

GabDug added 2 commits April 22, 2025 15:05
Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
@kurtaking
Copy link
Member

@kurtaking I've just replaced the yarn dev script, so it seems complete.

Thank you for the recent contributions 🙌🏼

@GabDug GabDug requested a review from vinzscam April 22, 2025 14:45
@kurtaking kurtaking enabled auto-merge (squash) April 22, 2025 14:50
@kurtaking
Copy link
Member

@vinzscam - I see you requested changes. Were those addressed?

@kurtaking kurtaking added the workspace/announcements Used to tag announcements workspace isses and pull requests label Apr 22, 2025
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kurtaking kurtaking merged commit 11be6bb into backstage:main Apr 24, 2025
12 checks passed
@GabDug GabDug deleted the announcements-backstage-138 branch April 28, 2025 08:31
@gaelgoth gaelgoth mentioned this pull request Apr 29, 2025
5 tasks
jaroslawgajewski pushed a commit to jaroslawgajewski/backstage-community-plugins that referenced this pull request Apr 30, 2025
* chore(announcements): Update to Backstage 1.38

Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>

* chore(announcements): Remove React imports and move to react-jsx

Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>

* chore: changeset

Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>

* chore: new launch scripts

Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>

* chore: fix React imports

Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>

* chore: upgrade to Backstage 1.38.1

Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>

---------

Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
Signed-off-by: Jarek <jaroslaw.gajewski@atos.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workspace/announcements Used to tag announcements workspace isses and pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants