Skip to content

chore(argocd): enable listDeprecations check#6752

Merged
christoph-jerolimov merged 11 commits intobackstage:mainfrom
dzemanov:argo-listDeprecations
Jan 15, 2026
Merged

chore(argocd): enable listDeprecations check#6752
christoph-jerolimov merged 11 commits intobackstage:mainfrom
dzemanov:argo-listDeprecations

Conversation

@dzemanov
Copy link
Copy Markdown
Contributor

@dzemanov dzemanov commented Jan 6, 2026

Hey, I just made a Pull Request!

Enable bcp.json listDeprecations option and fix argocd deprecations.
Replaces old @janus-idp/backstage-plugin-rbac-backend with @backstage-community/plugin-rbac-backend in the workspace.

Helps towards #5994.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@backstage-goalie
Copy link
Copy Markdown
Contributor

backstage-goalie Bot commented Jan 6, 2026

Unexpected Changesets

The following changeset(s) reference packages that have not been changed in this PR:

  • /home/runner/work/community-plugins/community-plugins/workspaces/argocd/.changeset/silver-papers-wash.md: @backstage-community/plugin-argocd

Note that only changes that affect the published package require changesets, for example changes to tests and storybook stories do not require changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/argocd/packages/app none v0.0.9
backend workspaces/argocd/packages/backend none v0.0.0
@backstage-community/plugin-argocd-backend workspaces/argocd/plugins/argocd-backend patch v1.0.1

@dzemanov
Copy link
Copy Markdown
Contributor Author

dzemanov commented Jan 6, 2026

Tested that after migration to permissionsRegistry, permissions work correctly:
Screenshot 2026-01-06 at 11 50 14
Screenshot 2026-01-06 at 11 49 43

Copy link
Copy Markdown
Member

@djanickova djanickova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! I also tested the permissions locally and can confirm that everything is working as expected, including the ArgoCD plugin showing up as an option in RBAC and not seeing the CD tab content when explicitly denying access to the user.

Don't forget the changeset though.

Screenshot 2026-01-09 at 12 37 24 Screenshot 2026-01-09 at 12 38 48

Copy link
Copy Markdown
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @dzemanov, as you know we renamed the plugin. Can you rebase/reapply these changes to the new workspace? 🙏

Comment thread workspaces/argocd/.changeset/silver-papers-wash.md
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
Copy link
Copy Markdown
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dzemanov 👍

@christoph-jerolimov christoph-jerolimov merged commit 9ed8237 into backstage:main Jan 15, 2026
13 checks passed
fjudith pushed a commit to alithya-oss/community-plugins that referenced this pull request Feb 19, 2026
@dzemanov dzemanov deleted the argo-listDeprecations branch April 14, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants