test(grafana): add comprehensive tests for API clients#7528
Open
andreahlert wants to merge 1 commit intobackstage:mainfrom
Open
test(grafana): add comprehensive tests for API clients#7528andreahlert wants to merge 1 commit intobackstage:mainfrom
andreahlert wants to merge 1 commit intobackstage:mainfrom
Conversation
Contributor
|
Thanks for the contribution! |
Add unit tests for GrafanaApiClient and UnifiedAlertingGrafanaApiClient covering dashboard listing, alert fetching, proxy path configuration, pagination behavior, error handling, and alert state aggregation logic. 33 new test cases covering previously untested API client functionality. Signed-off-by: André Ahlert <andre@aex.partners>
12611c8 to
3abb3b0
Compare
This was referenced Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive unit tests for
GrafanaApiClientandUnifiedAlertingGrafanaApiClient, which previously had zero test coverage.33 new test cases organized in the following categories:
GrafanaApiClient (legacy alerting)
/grafana/apipath, custom proxy pathUnifiedAlertingGrafanaApiClient (unified alerting)
Test plan