Create new Fairwinds Insights Backstage Plugin (new workspace)#7550
Create new Fairwinds Insights Backstage Plugin (new workspace)#7550awanlin merged 78 commits intobackstage:mainfrom
Conversation
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Changed Packages
|
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
|
@vinzscam hi there 👋 - just checking if there's any update or feedback on this? Happy to make changes / answer questions / rebase / etc. Thanks for your time! |
awanlin
left a comment
There was a problem hiding this comment.
Hi @vitorvezani, we often won't review PRs if the CI is failing and when I looked at this last that was the case. There was no indication help was asked for so we assume that you are working on it as you have time.
I didn't do a full review but please remove the example app and use the /dev/index pattern instead. This is something we very much want to avoid. 👍
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
chore: update issue templates with latest workspaces
|
Hi @vinzscam, just a friendly nudge to tell that everything should be in a better shape now and ready for a fresh look whenever you have a moment. Thanks a ton in advance. |
|
Hi @vitorvezani, sorry for the delay, with BackstageCon/KubeCon taking place this week many of us have been pretty busy with preparation and travels. I'll try to give this a look over soon, the internet at the airport on Friday was terrible which is when I had planned to look at this again :( |
|
Thanks for the contribution! |
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
|
Hi @vinzscam, just checking back on this when you have a moment. Let me know if there’s anything blocking the review or if I can help move this forward. Thanks! |
awanlin
left a comment
There was a problem hiding this comment.
Thanks for being patient with the speed of reviews @vitorvezani. Gave this a look over and it's very close. We really need to have the New Frontend system support in place as that's now the default.
…ge.json Co-authored-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com> Signed-off-by: Vitor Rodrigo Vezani <vitor.vezani@fairwinds.com>
…ge.json Co-authored-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com> Signed-off-by: Vitor Rodrigo Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Update Fairwinds Insights plugin to include new sidebar navigation and dependencies Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
|
All good @awanlin, thanks for getting back to me! I spent some time going through the docs, migration guide, and a few other plugins, and I think I’ve got the new frontend system set up properly now. One question though: since this is a new plugin, do we still need to support the old approach via the "Hybrid Configuration", or is it fine to stick with only the New Frontend System? I also put together a standalone app using the fairwinds-insights plugin extensions for reference: Let me know if you see anything else that should be improved or adjusted. |
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Signed-off-by: Vitor Vezani <vitor.vezani@fairwinds.com>
awanlin
left a comment
There was a problem hiding this comment.
Thanks for the follow up @vitorvezani, this is in a state that I think we should merge and release it. 🚀
|
@awanlin thanks for the guidance and patience. Now that the plugin is merged, should I ping someone about backstage/community#275? I got mentioned here #8636, but I don't have approval status for the plugin. |
Hey, I just made a Pull Request!
What was added
New workspace Fairwinds Insights that integrates Fairwinds Insights with Backstage.
Plugins
insights.fairwinds.com/app-groupsannotation.Screenshots






✔️ Checklist
Signed-off-byline in the message. (more info)