adr - version:bump to v1.50.3 by backstage-service · Pull Request #8580 · backstage/community-plugins

backstage-service · 2026-04-15T22:39:09Z

Backstage release v1.50.1 has been published, this Pull Request contains the changes to upgrade adr to this new release

Please review the changelog before approving, there may be manual changes needed:

Changelog: v1.50.1
Upgrade Helper: From 1.49.2 to 1.50.1

Created by Version Bump 24481949843

awanlin

Hi @kuangp, I triggered this version bump sooner as anyone who does the upgrade of their Backstage instance to 1.50.x and uses the search module will hit an error on start up - TypeError: Cannot read properties of undefined (reading 'id') - this is due to the breaking change removal of the catalogServiceRef alpha export.

awanlin · 2026-04-16T12:23:12Z

-      onBehalfOf: await this.auth.getOwnServiceCredentials(),
-      targetPluginId: 'catalog',
-    });
+    const credentials = await this.auth.getOwnServiceCredentials();


I'm not sure this is right, need to triple check.

Copilot

Pull request overview

Upgrades the ADR workspace/plugins to align with Backstage release v1.50.1, including adapting the ADR search backend module to updated catalog access patterns.

Changes:

Bump Backstage and related package dependencies across ADR workspace packages to versions compatible with v1.50.1.
Update search-backend-module-adr to use catalogServiceRef / CatalogService (and credentials-based calls) instead of the previous discovery + catalog client approach.
Update generated API reports and add a changeset for the version bump.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
workspaces/adr/plugins/search-backend-module-adr/src/index.ts	Switches to stable `catalogServiceRef` wiring and removes discovery dependency.
workspaces/adr/plugins/search-backend-module-adr/src/collators/DefaultAdrCollatorFactory.ts	Migrates collator catalog access from `CatalogClient`+discovery/token to `CatalogService`+credentials.
workspaces/adr/plugins/search-backend-module-adr/report.api.md	Reflects the updated public API surface for the backend module.
workspaces/adr/plugins/search-backend-module-adr/package.json	Dependency bumps for Backstage v1.50.1 compatibility.
workspaces/adr/plugins/adr/report-alpha.api.md	Generated API report updates (ordering/type surface changes).
workspaces/adr/plugins/adr/package.json	Dependency bumps for Backstage v1.50.1 compatibility.
workspaces/adr/plugins/adr-common/package.json	Dependency bumps for Backstage v1.50.1 compatibility.
workspaces/adr/plugins/adr-backend/package.json	Dependency bumps for Backstage v1.50.1 compatibility.
workspaces/adr/package.json	Updates tooling deps for Backstage v1.50.1 (cli/repo-tools, adds cli-defaults).
workspaces/adr/backstage.json	Updates declared Backstage version to 1.50.1.
workspaces/adr/.changeset/version-bump-1-50-1.md	Adds changeset to publish updated ADR packages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-20T23:31:18Z

+'@backstage-community/search-backend-module-adr': minor
+---
+
+Backstage version bump to v1.50.1


The changeset text only mentions a Backstage version bump, but this PR also introduces a breaking public API change in @backstage-community/search-backend-module-adr (collator options now require CatalogService and no longer accept CatalogApi + DiscoveryService). Please update the changeset description to call out the API change and migration guidance, and double-check the chosen bump level is consistent with how this repo communicates breaking changes for 0.x packages.

Suggested change

Backstage version bump to v1.50.1

Backstage version bump to v1.50.1.

`@backstage-community/search-backend-module-adr` also includes a breaking public API change in this release. The ADR collator options now require `CatalogService`; passing `CatalogApi` and `DiscoveryService` is no longer supported.

To migrate, update ADR collator construction to provide a `CatalogService` instance instead of the previous `CatalogApi` + `DiscoveryService` pair. The package version remains a `minor` bump here to match this repo's versioning approach for breaking changes in `0.x` packages.

Copilot · 2026-04-20T23:31:19Z

 export type AdrCollatorFactoryOptions = {
  /**
   * Function used to filter ADR file paths.
   * Defaults to filtering paths following MADR filename format.
   */
  adrFilePathFilterFn?: AdrFilePathFilterFn;
  /**
   * Plugin cache manager
   */
  cache: CacheService;
  /**
   * App Config
   */
  config: RootConfigService;
  /**
-   * Catalog API client. Defaults to CatalogClient.
-   */
-  catalogClient?: CatalogApi;
-  /**
-   * Plugin Endpoint Discovery client
+   * Catalog service client.
   */
-  discovery: DiscoveryService;
+  catalogClient: CatalogService;
  /**


AdrCollatorFactoryOptions is marked @public and is re-exported from the package, but this change replaces the previous catalogClient?: CatalogApi + discovery: DiscoveryService shape with a required catalogClient: CatalogService. That is a breaking API change for any consumers constructing DefaultAdrCollatorFactory directly. If external use is expected, consider keeping backwards compatibility (e.g., accepting both shapes / deprecating the old fields) or ensure the versioning + release notes clearly signal the breaking change and provide a migration path.

kuangp

Looks good - thanks for this!

kuangp · 2026-04-20T23:51:19Z

@awanlin I think this needs your approval to merge since you requested changes

Copilot

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-21T14:06:58Z

@@ -1,3 +1,3 @@
 {
-  "version": "1.49.2"
+  "version": "1.50.2"


The PR description/changelog links mention upgrading to Backstage v1.50.1, but this workspace is being bumped to 1.50.2 here. Please update the PR description (and any referenced changelog/upgrade-helper links) to match the actual target version, or adjust the version if 1.50.1 was intended.

Copilot · 2026-04-21T14:06:58Z

+'@backstage-community/search-backend-module-adr': minor
+---
+
+Backstage version bump to v1.50.2


This changeset filename suggests 1.50.1, but the content says the bump is to v1.50.2. Renaming the changeset file to reflect 1.50.2 would avoid confusion when scanning changesets/history.

Suggested change

Backstage version bump to v1.50.2

Backstage version bump to v1.50.1

kuangp · 2026-04-21T14:12:39Z

updated to bump to 1.50.2

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Signed-off-by: Phil Kuang <pkuang@factset.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-24T20:58:22Z

 {
-  "version": "1.49.2"
+  "version": "1.50.3"
 }


backstage.json bumps the workspace Backstage version to 1.50.3, but the PR title/changeset text indicate v1.50.2 (and most other workspaces are on 1.50.2). Please align this version with the intended target release, and update the PR metadata/changeset text accordingly if 1.50.3 is actually desired.

kuangp · 2026-04-24T21:01:36Z

updated to bump to 1.50.3
cc @awanlin to sign off

awanlin · 2026-04-28T11:54:51Z

Sorry for the hold up @kuangp, approved!

backstage-service requested review from a team and kuangp as code owners April 15, 2026 22:39

backstage-service requested a review from Parsifal-M April 15, 2026 22:39

backstage-service added the workspace/adr label Apr 15, 2026

awanlin requested changes Apr 16, 2026

View reviewed changes

kuangp reviewed Apr 20, 2026

View reviewed changes

Comment thread workspaces/adr/plugins/search-backend-module-adr/src/index.ts Outdated

Copilot AI review requested due to automatic review settings April 20, 2026 23:27

Copilot started reviewing on behalf of kuangp April 20, 2026 23:28 View session

kuangp force-pushed the adr/v1.50.1 branch from c6fb0e8 to 1c616aa Compare April 20, 2026 23:30

Copilot AI reviewed Apr 20, 2026

View reviewed changes

kuangp approved these changes Apr 20, 2026

View reviewed changes

kuangp enabled auto-merge (squash) April 20, 2026 23:50

kuangp changed the title ~~adr - version:bump to v1.50.1~~ adr - version:bump to v1.50.2 Apr 21, 2026

kuangp mentioned this pull request Apr 21, 2026

adr - version:bump to v1.50.2 #8683

Closed

Copilot AI review requested due to automatic review settings April 21, 2026 14:02

kuangp force-pushed the adr/v1.50.1 branch from 01db1b1 to a02acc5 Compare April 21, 2026 14:02

Copilot started reviewing on behalf of kuangp April 21, 2026 14:03 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

kuangp force-pushed the adr/v1.50.1 branch from a02acc5 to 631e92e Compare April 21, 2026 14:07

kuangp requested a review from awanlin April 21, 2026 14:12

github-actions Bot and others added 4 commits April 24, 2026 16:54

v1.50.1 version bump

ca6e271

fix(adr): apply v1.50.1 migration changes

55e673f

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Apply suggestions from code review

1cd9eaa

Signed-off-by: Phil Kuang <pkuang@factset.com>

chore(deps): bump to v1.50.2

7efb5f0

Signed-off-by: Phil Kuang <pkuang@factset.com>

Copilot AI review requested due to automatic review settings April 24, 2026 20:55

kuangp force-pushed the adr/v1.50.1 branch from 631e92e to 68c0400 Compare April 24, 2026 20:55

kuangp changed the title ~~adr - version:bump to v1.50.2~~ adr - version:bump to v1.50.3 Apr 24, 2026

Copilot started reviewing on behalf of kuangp April 24, 2026 20:56 View session

chore(deps): bump to 1.50.3

54e4e82

Signed-off-by: Phil Kuang <pkuang@factset.com>

kuangp force-pushed the adr/v1.50.1 branch from 68c0400 to 54e4e82 Compare April 24, 2026 20:56

Copilot AI reviewed Apr 24, 2026

View reviewed changes

awanlin approved these changes Apr 28, 2026

View reviewed changes

kuangp merged commit e43abbc into main Apr 28, 2026
16 checks passed

kuangp deleted the adr/v1.50.1 branch April 28, 2026 11:54

-Backstage version bump to v1.50.1
+Backstage version bump to v1.50.1.
+`@backstage-community/search-backend-module-adr` also includes a breaking public API change in this release. The ADR collator options now require `CatalogService`; passing `CatalogApi` and `DiscoveryService` is no longer supported.
+To migrate, update ADR collator construction to provide a `CatalogService` instance instead of the previous `CatalogApi` + `DiscoveryService` pair. The package version remains a `minor` bump here to match this repo's versioning approach for breaking changes in `0.x` packages.

	Backstage version bump to v1.50.2
	Backstage version bump to v1.50.1

Conversation

backstage-service commented Apr 15, 2026

Uh oh!

awanlin left a comment

Choose a reason for hiding this comment

Uh oh!

awanlin Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

kuangp left a comment

Choose a reason for hiding this comment

Uh oh!

kuangp commented Apr 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

kuangp commented Apr 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

kuangp commented Apr 24, 2026

Uh oh!

Uh oh!

awanlin commented Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants