Skip to content

fix: reload broken with latest click#321

Merged
awanlin merged 1 commit intobackstage:mainfrom
Believe-SA:click
Feb 2, 2026
Merged

fix: reload broken with latest click#321
awanlin merged 1 commit intobackstage:mainfrom
Believe-SA:click

Conversation

@GabDug
Copy link
Member

@GabDug GabDug commented Jan 30, 2026

Recommended to pin click, see squidfunk/mkdocs-material#8478, alternative of requiring users to always pass the --livereload flag would be a breaking change and would require some docs update.

Fixing it here should fix it transitively in techdocs-container - let me know if you prefer to only pin the dependency there.

@GabDug GabDug requested review from a team and awanlin as code owners January 30, 2026 10:38
@awanlin
Copy link
Collaborator

awanlin commented Jan 30, 2026

Hi @GabDug, can you look into the CI error?

@GabDug
Copy link
Member Author

GabDug commented Jan 30, 2026

Hi @GabDug, can you look into the CI error?

Yes sorry about that @awanlin!

Recommended to pin click, see squidfunk/mkdocs-material#8478, alternative of requiring users to always pass the `--livereload` flag would be a breaking change and would require some docs update.

Fixing it here should fix it transitively in techdocs-container - let me know if you prefer to only pin the dependency there.
Copy link
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GabDug, just want to get a quick review from the TechDocs maintainers as well before merging 👍

@awanlin awanlin merged commit e8d8a43 into backstage:main Feb 2, 2026
6 checks passed
@GabDug GabDug deleted the click branch February 3, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants