Skip to content

Use latest PlantUML jar file to download [1.2021.4]#11

Merged
emmaindal merged 3 commits intomainfrom
emmaindal/plantuml
Apr 19, 2021
Merged

Use latest PlantUML jar file to download [1.2021.4]#11
emmaindal merged 3 commits intomainfrom
emmaindal/plantuml

Conversation

@emmaindal
Copy link
Copy Markdown
Member

@emmaindal emmaindal commented Apr 19, 2021

Some usage of PlantUML (C4 diagrams for example) were broken because we use a very old version of the jar file we download. This upgrades that to the latest one and fix the parsing issues.

Before
Screen Shot 2021-04-19 at 2 06 21 PM

After
Screen Shot 2021-04-19 at 2 07 21 PM

Signed-off-by: Emma Indal <emmai@spotify.com>
Signed-off-by: Emma Indal <emmai@spotify.com>
@emmaindal emmaindal requested a review from a team as a code owner April 19, 2021 13:01
Comment thread Dockerfile Outdated
Signed-off-by: Emma Indal <emmai@spotify.com>
@emmaindal emmaindal requested a review from iamEAP April 19, 2021 13:13
Copy link
Copy Markdown
Member

@iamEAP iamEAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :shipit:

@emmaindal emmaindal merged commit 5322712 into main Apr 19, 2021
@emmaindal emmaindal deleted the emmaindal/plantuml branch April 19, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants