Fix issue with navigation icons#37
Merged
markvaneijk merged 3 commits intobackstagephp:mainfrom Apr 8, 2025
Merged
Conversation
Contributor
|
Good catch @Skullbock, thanks! |
Contributor
Author
|
No problem! I'm pretty interested in the aws ses integration as well, any way i can help? |
Contributor
|
Yeah, we need a PR on |
Contributor
Author
|
I saw that you mentioned that some work on that was already on the way, didn't want to overlap with any work you guys are already doing on that ;) |
Contributor
|
We're currently not working on this, we don't have the need right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Filament, the
getNavigationIconcan return null, which allows for disabling the navigation icon.In this plugin, the method on the resources forces the
stringreturn type, which prevents any override of the resource from removing the icon.