fix: Use navigation.group configuration in MailResource#59
Merged
Baspa merged 1 commit intobackstagephp:mainfrom Sep 26, 2025
Merged
fix: Use navigation.group configuration in MailResource#59Baspa merged 1 commit intobackstagephp:mainfrom
Baspa merged 1 commit intobackstagephp:mainfrom
Conversation
The MailResource was hardcoded to use '__('Emails')' as the navigation group,
ignoring the 'filament-mails.navigation.group' configuration option.
This change updates the getNavigationGroup() method to read from the config
with a fallback to the previous default value, allowing users to customize
the navigation group as intended.
Fixes backstagephp#58
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Fixed in v3.0.4, thanks @HelgeSverre! |
|
Hi @markvaneijk , this method not works! public static function getNavigationGroup(): ?string
{
return config('filament-mails.navigation.group', __('Emails'));
}In Laravel, So I think you should use like this public static function getNavigationGroup(): ?string
{
return __(config('filament-mails.navigation.group') ?? 'Emails');
}If need I can create PR for this. |
|
@markvaneijk, @Baspa this will not work, it will thrown error - 'navigation' => [
'group' => __('Emails'),
'sort' => 9,
], |
Contributor
|
You are correct @arshaviras, we've released v3.0.6 with a fix for this and added some extra configuration options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filament-mails.navigation.groupconfiguration option__('Emails')ignoring the configDetails
The issue was in
src/Resources/MailResource.php:61wheregetNavigationGroup()returned a hardcoded value instead of checking the configuration.Before:
After:
Test plan
config/filament-mails.phpCloses #58
🤖 Generated with Claude Code