cli: add-sources error behavior #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perf2711
force-pushed
the
feature/cli-add-sources-error-behavior
branch
from
8e091a8 to
3b0f066
Compare
konraddysput
approved these changes
Dec 11, 2023
| const skipped: string[] = []; | ||
| const failed: string[] = []; | ||
|
|
||
| const sourcesContent: string[] = sourceMap.sourcesContent ?? []; |
Collaborator
There was a problem hiding this comment.
just checking:
if we skip the source content, because someone added a js file without type definition, will sources array be bigger than sourcesContent array?
Contributor
Author
There was a problem hiding this comment.
no, I don't push to this array, I set the indices directly. If the file does not have an original source, the respective source content will be null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some changes to add-sources:
--source-error-behavior--forceis passed, all sources are treated as if they were not thereJira task: BT-2080