Skip to content

react-native: set transfer encoding to chunked #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2024
Merged

react-native: set transfer encoding to chunked #223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a149596
set transfer encoding to chunked
konraddysput Jan 3, 2024
89a05f3
Avoid creating form data when no attachments are available
konraddysput Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions packages/react-native/src/ReactNativeRequestHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ export class ReactNativeRequestHandler implements BacktraceRequestHandler {
private readonly JSON_HEADERS = {
'Content-type': 'application/json',
};
private readonly MULTIPART_HEADERS = {
'Transfer-Encoding': 'chunked',
};

constructor(
private readonly _options: {
Expand All @@ -29,8 +32,8 @@ export class ReactNativeRequestHandler implements BacktraceRequestHandler {
attachments: BacktraceAttachment<Blob | string>[],
abortSignal?: AbortSignal,
): Promise<BacktraceReportSubmissionResult<T>> {
const formData = this.createFormData(dataJson, attachments);
return this.post(submissionUrl, formData, abortSignal);
const payload = this.createSubmissionPayload(dataJson, attachments);
return this.post(submissionUrl, payload, abortSignal);
}

public async post<T>(
Expand All @@ -45,7 +48,7 @@ export class ReactNativeRequestHandler implements BacktraceRequestHandler {
const response = await fetch(submissionUrl, {
method: 'POST',
body: payload,
headers: typeof payload === 'string' ? this.JSON_HEADERS : {},
headers: typeof payload === 'string' ? this.JSON_HEADERS : this.MULTIPART_HEADERS,
signal: anySignal(abortSignal, controller.signal),
});

Expand Down Expand Up @@ -83,13 +86,15 @@ export class ReactNativeRequestHandler implements BacktraceRequestHandler {
}
}

private createFormData(json: string, attachments: BacktraceAttachment<Blob | string>[]) {
const formData = new FormData();
formData.append(this.UPLOAD_FILE_NAME, json);

private createSubmissionPayload(
json: string,
attachments: BacktraceAttachment<Blob | string>[],
): FormData | string {
if (!attachments || attachments.length === 0) {
return formData;
return json;
}
const formData = new FormData();
formData.append(this.UPLOAD_FILE_NAME, json);
for (const attachment of attachments) {
const data = attachment.get();
if (!data) {
Expand Down