Determine library name based on the namespace/function name #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able in the function name
vlussenburg
approved these changes
Nov 7, 2022
konraddysput
added a commit
that referenced
this pull request
Nov 29, 2022
* Fix inalid stack frame type (#172) * Stack frame algorithm improvements * Parse correctly xbox stack frames without source information from the managed thread * Support for unknown universe based on the URL (#171) * Android native error reporting binaries update (#169) * Crashpad new binaries * Crashpad binaries update * Remove logs * Bring back enter in the native class implementation * Preview version update * Updates README (#168) Updates README to only include badges, description, installation and usage code samples, and link to the docs for more info. * Replace crashpad handler (#174) * Always try to determine the library name based on the namespace available in the function name (#175) * Replace libbacktrace-native.so (#176) * Add files via upload * Revert to previous version https://github.com/backtrace-labs/backtrace-unity/blob/ebe06b354c98bd35e9f123c4b3b03afafb46db9a/Android/lib/armeabi-v7a/libcrashpad_handler.so * Delete Documentation~ directory (#177) * Preview 2 * Added device.machine attribute * Removed alpha tag Co-authored-by: Lysanne Pinto <lysannepinto@gmail.com> Co-authored-by: Vincent Lussenburg <vlussenburg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In the past Backtrace-Unity did generate an empty library name if the source code information was empty OR provided pre-generated information like
<123123123: 0>- no information about source code.Right now, backtrace-unity plugin will try to determine the library name based on the namespace