metrics: retry submission on connection failure #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konraddysput
requested changes
Nov 8, 2023
Collaborator
konraddysput
left a comment
konraddysput
left a comment
There was a problem hiding this comment.
I strongly believe we don't need those changes. Please see my comments
gm4sl
force-pushed
the
gm4sl/metrics-retry
branch
from
0e74546 to
5f37e2e
Compare
gm4sl
changed the title
konraddysput
requested changes
Nov 8, 2023
Previously, only a subset protocol errors would be considered for retry when submitting metrics (summed or unique) to events.backtrace.io. This excluded, notably, a failure to connect to the server at all. If the device was offline at startup, for instance, then the "Application Launches" event would never get sent. This commit changes the handling so that any network error will also go through the retry logic for submitting an event.
gm4sl
force-pushed
the
gm4sl/metrics-retry
branch
from
5f37e2e to
04bf084
Compare
konraddysput
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only a subset protocol errors would be considered for retry when submitting metrics (summed or unique) to events.backtrace.io. This excluded, notably, a failure to connect to the server at all. If the device was offline at startup, for instance, then the "Application Launches" event would never get sent.
This commit changes the handling so that any network error will also go through the retry logic for submitting an event.