-
Notifications
You must be signed in to change notification settings - Fork 35
Version 3.3.1 - native improvements #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… warning occured. Let native integration handle it
rqbacktrace
reviewed
Feb 24, 2021
rqbacktrace
reviewed
Feb 24, 2021
rqbacktrace
reviewed
Feb 24, 2021
|
Looks good, just found some spacing issues |
rqbacktrace
reviewed
Feb 24, 2021
rqbacktrace
reviewed
Feb 24, 2021
rqbacktrace
approved these changes
Feb 24, 2021
jasoncdavis0
approved these changes
Feb 24, 2021
Contributor
jasoncdavis0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the change log and description of PR.
vlussenburg
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backtrace-Unity 3.3.1 update
This patch adjusts the approach Backtrace-unity uses to detect low memory situations. Previously Backtrace report low memory warning to Backtrace when the lowMemoryWarning callback occurred. This updated approach allows the system to detect out-of-memory crashes via a native OS library and adjustments to the data collected by Backtrace.
On iOS - The system reports the out-of-memory exception when the lowMemoryWarning occurred and when the application unexpectedly exits. On the next application startup, Backtrace will analyze the status file. If the status file is available and the following conditions are met, then the Backtrace-Unity integration sends an OutOfMemory exception to Backtrace. The conditions that are checked are:
On Android - The report generated was extended with attributes to let developers know the following information:
Testing strategy
on Android (oom enabled)
Run the application that generates a lot of textures to see how the application performs with out of memory exception and try to generate crash with attributes
on iOS (oom enabled)
validate if the status file is generated on application startup with basic information about the application
validate if the status file has application version, systemVersion, debug information on the application startup,
validate if application stores low memory warning when the lowMemoryWarning event occurred,
validate if application stores report attributes when the lowMemoryWarning event occurred,
validate if application upload the out of memory report when application version, systemVersion, debugging information are the same,
validate if the application doesn't upload the out of memory report when application version, systemVersion, debugging information are the same,
on iOS (oom disabled)
check if status json file is generated,
check if notification are generated when lowMemoryWarning or other events happening.