Extra Hset functions#8
Merged
backtracking merged 4 commits intobacktracking:masterfrom Jan 28, 2024
dlesbre:hset-functions
Merged
Extra Hset functions#8backtracking merged 4 commits intobacktracking:masterfrom dlesbre:hset-functions
backtracking merged 4 commits intobacktracking:masterfrom
dlesbre:hset-functions
Conversation
Merged
Contributor
Author
|
@backtracking any review for this ? |
Owner
|
Thanks @dlesbre for the patch and apologies for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are most of the missing function between
HsetandSet.S. The notable exceptions areto_seq_revandto_seq_fromsince the only reasonable way I could implement them is convert to list, then sort, then convert to seq...I feel this bypasses the point of these function (provide efficient iterators). I did include
to_seqbut with the caveat that the result isn't sorted.To be honest the order on hash consed terms is arbitrary anyway so I don't see anyone using these. Its also why I added a custom
find_anyanfind_any_optfunctions, as these seem more useful and can me made a bit faster.