Skip to content

remove old syncthing option insecureAllowOldTLSVersions#1960

Merged
openshift-merge-bot[bot] merged 1 commit intobackube:mainfrom
tesshuflower:syncthing-remove-unused-insecureAllowOldTLSVersions
Mar 27, 2026
Merged

remove old syncthing option insecureAllowOldTLSVersions#1960
openshift-merge-bot[bot] merged 1 commit intobackube:mainfrom
tesshuflower:syncthing-remove-unused-insecureAllowOldTLSVersions

Conversation

@tesshuflower
Copy link
Copy Markdown
Contributor

  • was previously set in our config-template.xml
  • Syncthing removed this in v1.29.6 and has forced TLS 1.3 since, so this option now appears to be ignored.

Describe what this PR does

Is there anything that requires special attention?

Related issues:

- was previously set in our config-template.xml
- Syncthing removed this in v1.29.6 and has forced TLS 1.3
  since.

Signed-off-by: Tesshu Flower <tflower@redhat.com>
@sonarqubecloud
Copy link
Copy Markdown

@tesshuflower
Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@tesshuflower
Copy link
Copy Markdown
Contributor Author

/retest

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.9%. Comparing base (7e438d1) to head (41b4f01).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1960     +/-   ##
=======================================
- Coverage   69.0%   68.9%   -0.1%     
=======================================
  Files         58      58             
  Lines       6072    6072             
=======================================
- Hits        4192    4186      -6     
- Misses      1571    1574      +3     
- Partials     309     312      +3     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tesshuflower
Copy link
Copy Markdown
Contributor Author

/cc @JohnStrunk

@openshift-ci openshift-ci Bot requested a review from JohnStrunk March 27, 2026 13:15
Copy link
Copy Markdown
Member

@JohnStrunk JohnStrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JohnStrunk,tesshuflower]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 6710596 into backube:main Mar 27, 2026
38 checks passed
@tesshuflower tesshuflower deleted the syncthing-remove-unused-insecureAllowOldTLSVersions branch March 27, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants