Skip to content

Conversation

@ousmaneNdiaye
Copy link
Contributor

Either I don't understand the meaning...

Either I  don't understand the meaning...
@wartab
Copy link
Contributor

wartab commented Mar 4, 2019

Yes, you don't understand.

@ShawnMcCool
Copy link

ShawnMcCool commented Mar 4, 2019

This is a chance to correct the opportunity for misunderstanding by proposing a more clear explanation.

Perhaps instead of

'Storage type "%s" has valid keys "%s" but got "%s"',

it could be

Storage type X received invalid key Y. Please choose one of Z.

Anyone have other ideas?

@Nyholm
Copy link
Member

Nyholm commented Mar 19, 2019

Thank you @ShawnMcCool. That sounds like a great idea.

@ousmaneNdiaye could you update the PR?

Added a more explicit error message
@ousmaneNdiaye ousmaneNdiaye changed the title typo ? Error message explanation Mar 20, 2019
@Nyholm Nyholm merged commit 2203a0e into backup-manager:master Apr 17, 2019
@Nyholm
Copy link
Member

Nyholm commented Apr 17, 2019

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants