[pull] master from BYVoid:master#105
Merged
Merged
Conversation
* Add smoke tests in appveyor - Limit AppVeyor npm packages to Windows prebuilds - Tighten AppVeyor npm build matrix - Use WinGet release script in AppVeyor * Fix WinGet release version detection * Ignore CMake warnings in WinGet release script
Agent-Logs-Url: https://github.com/BYVoid/OpenCC/sessions/7a2afa4d-0bcb-4512-a66f-f066fe7dffad Co-authored-by: frankslin <748873+frankslin@users.noreply.github.com>
* Fix CMake warnings in release build * Check native command exits in WinGet script
* Share C++ streaming conversion with Node CLI Move chunk boundary handling into a reusable ConverterStream in the C++ core so native CLI and Node bindings share UTF-8 and phrase-boundary behavior. Expose the stream state through the Node native addon and update the npm CLI to use a Transform pipeline instead of reading the whole input into memory. The JS layer now handles only Node stream plumbing and leaves conversion state to C++. Add CLI coverage for phrase conversion across stream chunk boundaries. * Keep reading after short stream reads Do not treat every short fread as EOF in ConvertStream. Short reads can happen on pipes and TTYs while more data is still pending, so only finish the ConverterStream chunk after EOF has actually been observed. Add CLI regression coverage for a pipe that writes input in separate chunks. The test verifies conversion continues after the first short read and still preserves phrase conversion across the pipe boundary. * Reject same-file Node CLI conversion Check --input and --output before opening the Node CLI streams. This prevents createWriteStream from truncating the source file when both options refer to the same path or filesystem object. Add npm CLI coverage that verifies the command fails and preserves the original file contents instead of attempting in-place conversion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )