fix: uses appropriate typings for property read/write request payloads#78
Open
jacoscaz wants to merge 1 commit intobacnet-js:masterfrom
Open
fix: uses appropriate typings for property read/write request payloads#78jacoscaz wants to merge 1 commit intobacnet-js:masterfrom
jacoscaz wants to merge 1 commit intobacnet-js:masterfrom
Conversation
This commit fixes a mistyping affecting read/write request payloads. For some reason, the payloads of events modelling read/write requests had been defined separately and independently of the payloads actually returned by the .decode() function of the service handler matching the incoming request. See src/lib/client.ts@530 for the parser invocation See src/lib/client.ts@557 for triggering of service request events
robertsLando
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a mistyping affecting read/write request payloads. For some reason, the payloads of events modelling read/write requests had been defined separately and independently of the payload actually returned by the .decode() function of the service handler matching the incoming request.
See src/lib/client.ts@530 for the parser invocation
See src/lib/client.ts@557 for triggering of service request events
I need this to surface the
priorityvalue at the typings level, so that I may use it to address bacnet-js/device#32 .