mch2022: More i2c fixes / workaround for readfrom_mem#28
Merged
Conversation
In the previous version we just refused all transfers that don't properly generate a STOP at the end. But the way the micropython code is written the readfrom_mem command will generate a write without stop then a read. We can't support that as two different commands, we we detect that access pattern, store the small write temporarely (it's the register address), then merge it with the following read command when it comes. Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous version we just refused all transfers that don't
properly generate a STOP at the end. But the way the micropython
code is written the readfrom_mem command will generate a write without
stop then a read.
We can't support that as two different commands, we we detect that
access pattern, store the small write temporarely (it's the register
address), then merge it with the following read command when it
comes.
Signed-off-by: Sylvain Munaut tnt@246tNt.com