Divide Distance to Plane by Normal Vector Magnitude #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellevahdat
requested review from
Jannetty and
jessicasyu
and removed request for
jessicasyu
daniellevahdat
changed the base branch from
main
to
jannetty/add-custom-plane-splitvoxels
daniellevahdat
changed the title
Jannetty
added a commit
that referenced
this pull request
Oct 11, 2024
* changed docstrung for getDirection to specify that it gets direction with shortest diameter through location * adding initial Plane, Point, Vector classes and associated tests * adding last file * adding Plane container and Plane factory to make planes from potts enums * wip many tests failing, fixing PottsLocationTest.java * corrected normal vectors in PottsPlaneFactory. Updated tests. Added tests. * moved all points and vectors to int3Ds, expanded direction enum, removed plane factory and container * small changes to PottsEnums test, formatting fixes * removed extra split function * Divide Distance to Plane by Normal Vector Magnitude (#52) * Signed distance to plane and tests for plane class * Signed distance to plane and tests * updated tests, renamed function --------- Co-authored-by: Danielle Vahdat <daniellevahdat@MacBook-Air-683.local> Co-authored-by: daniellevahdat <dhvahdat@gmail.com> Co-authored-by: jannetty <jannetty@uw.edu> * moved Plane to Potts, changed point type to Voxel, removed unused function * change plane to have point represented as voxel instead of int3d * changed signedDistance function to take voxel * updated test * changed enum back, formatting fixes * removing test.class * Update src/arcade/potts/env/location/PottsLocation.java Co-authored-by: Jessica S. Yu <15913767+jessicasyu@users.noreply.github.com> * addressing Jess's comments. Normalizing plane normal vector. * formatting fixes * added a few white spaces * Update src/arcade/potts/env/location/PottsLocation.java Co-authored-by: Jessica S. Yu <15913767+jessicasyu@users.noreply.github.com> * Update test/arcade/potts/env/location/PottsLocationTest.java Co-authored-by: Jessica S. Yu <15913767+jessicasyu@users.noreply.github.com> --------- Co-authored-by: daniellevahdat <158232064+daniellevahdat@users.noreply.github.com> Co-authored-by: Danielle Vahdat <daniellevahdat@MacBook-Air-683.local> Co-authored-by: daniellevahdat <dhvahdat@gmail.com> Co-authored-by: Jessica S. Yu <15913767+jessicasyu@users.noreply.github.com>
Jannetty
added a commit
that referenced
this pull request
Oct 18, 2024
* changed docstrung for getDirection to specify that it gets direction with shortest diameter through location * adding initial Plane, Point, Vector classes and associated tests * adding last file * adding Plane container and Plane factory to make planes from potts enums * wip many tests failing, fixing PottsLocationTest.java * corrected normal vectors in PottsPlaneFactory. Updated tests. Added tests. * moved all points and vectors to int3Ds, expanded direction enum, removed plane factory and container * small changes to PottsEnums test, formatting fixes * removed extra split function * Divide Distance to Plane by Normal Vector Magnitude (#52) * Signed distance to plane and tests for plane class * Signed distance to plane and tests * updated tests, renamed function --------- Co-authored-by: Danielle Vahdat <daniellevahdat@MacBook-Air-683.local> Co-authored-by: daniellevahdat <dhvahdat@gmail.com> Co-authored-by: jannetty <jannetty@uw.edu> * moved Plane to Potts, changed point type to Voxel, removed unused function * change plane to have point represented as voxel instead of int3d * changed signedDistance function to take voxel * updated test * changed enum back, formatting fixes * removing test.class * Update src/arcade/potts/env/location/PottsLocation.java Co-authored-by: Jessica S. Yu <15913767+jessicasyu@users.noreply.github.com> * addressing Jess's comments. Normalizing plane normal vector. * formatting fixes * added a few white spaces * Update src/arcade/potts/env/location/PottsLocation.java Co-authored-by: Jessica S. Yu <15913767+jessicasyu@users.noreply.github.com> * Update test/arcade/potts/env/location/PottsLocationTest.java Co-authored-by: Jessica S. Yu <15913767+jessicasyu@users.noreply.github.com> --------- Co-authored-by: daniellevahdat <158232064+daniellevahdat@users.noreply.github.com> Co-authored-by: Danielle Vahdat <daniellevahdat@MacBook-Air-683.local> Co-authored-by: daniellevahdat <dhvahdat@gmail.com> Co-authored-by: Jessica S. Yu <15913767+jessicasyu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed distance to plane and tests for plane class