fix: navigate to heading for internal anchor links#16
Merged
Conversation
Handle #anchor links in the link picker by matching against TOC headings instead of blocking them as unsupported URL schemes. Closes #14.
Use idiomatic filter_map, Unicode-aware lowercasing, and add unit tests covering basic slugs, punctuation, consecutive hyphens, Unicode, and edge cases.
Handle multi-char Unicode lowercasing (e.g. ß→ss), collapse consecutive hyphens, and trim leading/trailing hyphens to align with GitHub's slug algorithm. Add tests for these edge cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[foo](#foo)) now navigate to the matching heading instead of being blocked as unsupported URL schemesheading_to_slug()function that converts heading text to GitHub-style anchor slugs for matchingTest plan
[foo](#foo)with a# fooheading)l), select the anchor link, and verify it scrolls to the headinghttp://,https://,mailto:) still open normally