fix(markdown): preserve link styling inside table cells#38
Merged
Conversation
It turns out the Event::Text handler checks `in_table` *before* `in_link`, so when text lives inside both a table cell and a link, the table branch wins and the link URL is quietly discarded. The link gets no color, no underline, and never shows up in the link picker. Check `in_link` inside the table branch and apply link styling when both flags are true. Four lines, fixes #26.
Add a "Links in Tables" table with internal anchor and external links (crates.io, docs.rs) so the fix from #26 is easy to verify visually — these links are distinct from the ones already in the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Event::Texthandler checkedin_tablebeforein_link, so link URL/styling was silently discarded for table cell contentin_linkcheck inside the table branch to apply link color, underline, andlink_urlmetadataTest plan
cargo run -- test.md— verify the "Links in Tables" section shows colored, underlined linksf(LinkPicker) — verify table links (crates.io, docs.rs, #math-rendering anchor) appear in the listcargo clippyandcargo testpass cleanly