Skip to content

Implement the main loop#180

Merged
bahmanm merged 96 commits intomasterfrom
implement-main-loop
Dec 14, 2024
Merged

Implement the main loop#180
bahmanm merged 96 commits intomasterfrom
implement-main-loop

Conversation

@bahmanm
Copy link
Copy Markdown
Owner

@bahmanm bahmanm commented Dec 10, 2024

Build a main loop and fix the potential plumbing problems in how the system works for the loop to work.

@bahmanm
Copy link
Copy Markdown
Owner Author

bahmanm commented Dec 10, 2024

The line in Primitive which used to set NIP has been removed.

It's a rather drastic departure from the initial implementation.

The reason behind this is to mimic free assmebler jmps in JONESFORTH which was previously impossible as next would overwrite NIP after every execution.

@bahmanm
Copy link
Copy Markdown
Owner Author

bahmanm commented Dec 10, 2024

All tests that verify the value of NIP must be modified to adapt to the new Primitive#call().

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.64%. Comparing base (f2caefd) to head (cff1d4d).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #180      +/-   ##
============================================
- Coverage     82.89%   81.64%   -1.26%     
- Complexity      384      385       +1     
============================================
  Files            87       87              
  Lines          1479     1509      +30     
  Branches        214      216       +2     
============================================
+ Hits           1226     1232       +6     
- Misses          186      207      +21     
- Partials         67       70       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bahmanm bahmanm merged commit 1712634 into master Dec 14, 2024
@bahmanm bahmanm deleted the implement-main-loop branch December 14, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants