Skip to content

Feat: Make helm flags timeout and force configurable#648

Merged
tobbber merged 20 commits into
mainfrom
ft/configurable-helm-flags
Jun 2, 2026
Merged

Feat: Make helm flags timeout and force configurable#648
tobbber merged 20 commits into
mainfrom
ft/configurable-helm-flags

Conversation

@tobbber
Copy link
Copy Markdown
Contributor

@tobbber tobbber commented Jun 1, 2026

Closes #647

@tobbber tobbber self-assigned this Jun 1, 2026
Comment thread tests/component_handlers/helm_wrapper/test_helm_diff.py
@tobbber tobbber changed the title Feat: Make helm flags configurable Feat: Make helm flags timeout and force configurable Jun 1, 2026
@tobbber tobbber requested a review from Copilot June 1, 2026 12:58
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds configuration knobs for Helm’s --timeout and --force behavior, exposing them via global HelmConfig (and timeout additionally at the individual HelmApp level) and updating docs/schemas/tests accordingly.

Changes:

  • Add timeout (global + per-HelmApp) and force_replace (global) to Helm configuration/models.
  • Wire timeout precedence (local → global → default) into Helm flag construction and add tests for precedence.
  • Regenerate/update JSON schemas, env var docs, and CLI init snapshot to reflect the new config fields.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_kpops_config.py Asserts new HelmConfig defaults (timeout, force_replace).
tests/components/test_helm_app.py Adds tests for timeout precedence and global force_replace wiring.
tests/component_handlers/helm_wrapper/test_helm_diff.py Adjusts logging capture in Helm diff test.
tests/cli/snapshots/test_init/test_init_project_include_optional/config.yaml Updates init snapshot with new helm_config fields.
kpops/components/base_components/helm_app.py Adds per-app timeout and applies global force_replace/timeout into flags.
kpops/components/base_components/cleaner.py Applies timeout precedence to Cleaner Helm flags.
kpops/component_handlers/helm_wrapper/model.py Extends HelmConfig with timeout/force_replace; updates Helm flags model.
docs/docs/schema/pipeline.json Adds timeout field to HelmApp-derived component schemas.
docs/docs/schema/defaults.json Adds timeout field to HelmApp-derived component schemas (defaults schema).
docs/docs/schema/config.json Adds helm_config.timeout and helm_config.force_replace to config schema.
docs/docs/resources/variables/config_env_vars.md Documents new env vars for helm timeout/force_replace.
docs/docs/resources/variables/config_env_vars.env Adds new env var entries for helm timeout/force_replace.
docs/docs/resources/pipeline-components/dependencies/kpops_structure.yaml Documents timeout as a component field in the pipeline structure docs.
Comments suppressed due to low confidence (1)

kpops/components/base_components/helm_app.py:151

  • helm_config.force_replace is currently added to the shared helm_flags, which are reused for template_flags. This means --force will also be passed to helm template when force_replace is enabled, even though --force is an upgrade/install concern and can break templating/manifest generation. Consider explicitly disabling force for HelmTemplateFlags so helm template stays unaffected by this setting.
    @property
    def template_flags(self) -> HelmTemplateFlags:
        """Return flags for Helm template command."""
        return HelmTemplateFlags(
            **self.helm_flags.model_dump(),
            api_version=get_config().helm_config.api_version,
        )

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread kpops/components/base_components/cleaner.py
Comment thread docs/docs/schema/config.json
@tobbber tobbber marked this pull request as ready for review June 1, 2026 13:04
@tobbber tobbber requested a review from disrupted as a code owner June 1, 2026 13:04
Comment thread tests/components/test_helm_app.py Outdated
Comment thread kpops/component_handlers/helm_wrapper/model.py Outdated
tobbber and others added 5 commits June 1, 2026 15:35
Co-authored-by: Salomon Popp <hi@salomonpopp.me>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small remark, other than that LGTM

Comment thread kpops/component_handlers/helm_wrapper/model.py Outdated
tobbber and others added 4 commits June 2, 2026 11:06
@tobbber tobbber enabled auto-merge (squash) June 2, 2026 11:47
@tobbber tobbber merged commit c00da33 into main Jun 2, 2026
10 checks passed
@tobbber tobbber deleted the ft/configurable-helm-flags branch June 2, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Helm flags timeout and force configurable.

3 participants