Skip to content

Add cleanup possibility on processor startup#15

Merged
fapaul merged 10 commits intomasterfrom
test_reprocessing
Jul 12, 2019
Merged

Add cleanup possibility on processor startup#15
fapaul merged 10 commits intomasterfrom
test_reprocessing

Conversation

@fapaul
Copy link
Copy Markdown
Contributor

@fapaul fapaul commented Jul 11, 2019

No description provided.

@fapaul fapaul requested review from SvenLehmann and lawben July 11, 2019 14:29
Comment thread src/main/java/com/bakdata/common_kafka_streams/KafkaStreamsApplication.java Outdated
…lication.java

Co-Authored-By: Lawrence Benson <github@lawben.com>
Comment thread src/test/java/com/bakdata/common_kafka_streams/test_applications/Mirror.java Outdated
// Wait here to let cleanUp and resetting finish .
Thread.sleep(5000);
} catch (InterruptedException e) {
e.printStackTrace();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably propagate and end the application.

Comment thread src/test/java/com/bakdata/common_kafka_streams/WordCountTest.java Outdated
this.mirror.setBrokers(this.kafkaCluster.getBrokerList());
this.mirror.setProductive(false);

this.kafkaCluster
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks bad

import org.apache.kafka.streams.kstream.KStream;
import picocli.CommandLine.Command;

@Command(name = "mirror")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this?

import picocli.CommandLine.Command;

@Command(name = "mirror")
@Getter
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@Getter


@Command(name = "mirror")
@Getter
@Setter
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@Setter

Comment thread src/test/java/com/bakdata/common_kafka_streams/test_applications/WordCount.java Outdated
Comment thread src/test/java/com/bakdata/common_kafka_streams/test_applications/WordCount.java Outdated
Comment thread src/test/java/com/bakdata/common_kafka_streams/test_applications/WordCount.java Outdated
fapaul and others added 5 commits July 11, 2019 17:23
…ns/WordCount.java

Co-Authored-By: Lawrence Benson <github@lawben.com>
…ns/WordCount.java

Co-Authored-By: Lawrence Benson <github@lawben.com>
…ns/WordCount.java

Co-Authored-By: Lawrence Benson <github@lawben.com>
Co-Authored-By: Lawrence Benson <github@lawben.com>
@fapaul fapaul merged commit c9d842b into master Jul 12, 2019
@fapaul fapaul deleted the test_reprocessing branch July 12, 2019 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants