Conversation
fapaul
force-pushed
the
kafka_streams_application
branch
from
0da7f23 to
94eea76
Compare
AHeise
reviewed
Mar 13, 2019
|
|
||
| repositories { | ||
| mavenCentral() | ||
| maven { |
There was a problem hiding this comment.
it's enough to write maven(url = "http://packages.confluent.io/maven/")
AHeise
approved these changes
Mar 13, 2019
AHeise
left a comment
AHeise
left a comment
There was a problem hiding this comment.
Small improvement in gradle.
You could try to increase test coverage by using word count (or similar): https://github.com/bakdata/fluent-kafka-streams-tests/tree/master/fluent-kafka-streams-tests/src/test/java/com/bakdata/fluent_kafka_streams_tests
fapaul
force-pushed
the
kafka_streams_application
branch
from
09fe1a2 to
565f510
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a base class for writing and configuring new Kafka streams processors.
Closes #1.