Skip to content

Change reprocessing to clean up#26

Merged
philipp94831 merged 12 commits intomasterfrom
feature/clean-up
Oct 14, 2019
Merged

Change reprocessing to clean up#26
philipp94831 merged 12 commits intomasterfrom
feature/clean-up

Conversation

@torbsto
Copy link
Copy Markdown
Contributor

@torbsto torbsto commented Oct 2, 2019

Starting the application with the cleanUp flag, all corresponding state dirs, offsets und internal topics are deleted. However, it does not reprocess the data and exists when it is done.

@torbsto torbsto requested a review from philipp94831 October 2, 2019 08:21
Comment thread src/test/java/com/bakdata/common_kafka_streams/WordCountTest.java Outdated
philipp94831
philipp94831 previously approved these changes Oct 3, 2019
"Mirror contains all elements after first run");

this.runCleanUpWithDeletion(this.app);
// recreate deleted topic
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an assert that the topic does not exist

private boolean cleanUp = false;

@CommandLine.Option(names = "--delete-output", arity = "1",
description = "Delete the output topic during the clean up. ")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing space

@philipp94831 philipp94831 merged commit 5c3952d into master Oct 14, 2019
@torbsto torbsto deleted the feature/clean-up branch November 26, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants