Call close on KafkaApplication only once#275
Merged
philipp94831 merged 2 commits intomasterfrom Jan 23, 2025
Merged
Conversation
torbsto
reviewed
Jan 23, 2025
Contributor
torbsto
left a comment
torbsto
left a comment
There was a problem hiding this comment.
I think a test would be helpful to ensure it is called only once
Member
Author
I tried, the problem is that the shutdown hook is not invoked in the tests. We avoid system.exit with a junit plugin but this also avoids the shutdown hook. If we allow system.exit, Gradle tests are aborted |
torbsto
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #263