Classify all Kafka errors as recoverable bar some exceptions#38
Merged
philipp94831 merged 4 commits intomasterfrom Nov 15, 2019
Merged
Classify all Kafka errors as recoverable bar some exceptions#38philipp94831 merged 4 commits intomasterfrom
philipp94831 merged 4 commits intomasterfrom
Conversation
SvenLehmann
reviewed
Nov 15, 2019
| return false; | ||
| } | ||
| if (e instanceof SerializationException) { | ||
| return e.getCause() instanceof SocketTimeoutException; |
SvenLehmann
approved these changes
Nov 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most Kafka errors are either recoverable or should stop processing. Therefore, they should be forwarded by default by all error handlers.
Furthermore, the clean up only logged errors upon schema registry clean up. This behavior has been changed to a thrown exception.