Override log4j.properties when using provided#62
Merged
b-feldmann merged 11 commits intomasterfrom Mar 24, 2020
Merged
Conversation
…ia helm --set-file log4jConfig=FILE_PATH
…ia helm --set-file log4jConfig=FILE_PATH
…ia helm --set-file log4jConfig=FILE_PATH
…ia helm --set-file log4jConfig=FILE_PATH
…ia helm --set-file log4jConfig=FILE_PATH
| @@ -0,0 +1 @@ | |||
| {{ if .Values.log4jConfig }}apiVersion: v1kind: ConfigMapmetadata: name: {{ template "streams-app.name" . }}-log4j-configmapdata: log4j.properties: |{{ .Values.log4jConfig | indent 4 }}{{ end }} No newline at end of file | |||
Member
There was a problem hiding this comment.
Is that supposed to be just one line?
Contributor
Author
There was a problem hiding this comment.
This is strange. This file has 9 lines on my file system. I will push the file with linux line endings again
Member
|
@BJennWare Please also make the changes to the statefulset |
| name: {{ template "streams-app.name" . }}-log4j-configmap | ||
| data: | ||
| log4j.properties: | | ||
| {{ .Values.log4jConfig | indent 4 }} |
Member
There was a problem hiding this comment.
What is the purpose of this? Can I still configure log4j.properties via values.yaml? Or just mount a file?
Contributor
Author
There was a problem hiding this comment.
We cannot just mount a file into helm. If we use helm --set-file log4jConfig=FILE_PATH than the contents of the file are in .Values.log4jConfig.
TLDR: We change the log config by mounting a log4j.properties file with --set-file
philipp94831
approved these changes
Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log4j.properties can be provided for helm with --set-file FILE_PATH