Skip to content

fix(ci): repair corrupt shellcheck.yml and docker_aliases.sh issues#4

Merged
bakerboy448 merged 4 commits intomainfrom
fix/corrupt-shellcheck-workflow
Apr 19, 2026
Merged

fix(ci): repair corrupt shellcheck.yml and docker_aliases.sh issues#4
bakerboy448 merged 4 commits intomainfrom
fix/corrupt-shellcheck-workflow

Conversation

@bakerboy448
Copy link
Copy Markdown
Collaborator

@bakerboy448 bakerboy448 commented Apr 19, 2026

Summary

  • Replace 0x01 control character that corrupted the jobs: key in shellcheck.yml, causing all CI workflow runs to fail
  • Add # shellcheck disable=SC2086 on 5 grp* functions where $services word-splitting is intentional (space-separated list passed as multiple args to docker compose)
  • Exclude docker_aliases.sh from shfmt — contains zsh-specific ${(f)...} parameter expansion that shfmt cannot parse

Test plan

  • All pre-commit hooks pass locally (verified: shellcheck, shfmt, actionlint, yamllint, check-yaml all pass)
  • CI workflow runs after merge

Summary by CodeRabbit

  • Chores
    • Fixed GitHub Actions workflow configuration syntax to ensure proper job definitions.
    • Updated pre-commit hook configuration to exclude a shell script file from automatic formatting.
    • Added inline validation directives to shell script commands to maintain compatibility with linting tools.

…docker_aliases from shfmt

- Replace 0x01 control char (corrupted jobs: key) in shellcheck.yml
- Add # shellcheck disable=SC2086 on 5 grp* functions — word splitting
  intentional for space-separated $services list passed to docker compose
- Exclude docker_aliases.sh from shfmt — zsh ${(f)...} syntax is
  incompatible with shfmt parser
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 19, 2026

Warning

Rate limit exceeded

@bakerboy448 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 33 minutes and 38 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 33 minutes and 38 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: fe7e0ec7-34c4-4f25-ba44-2f31f420fa0d

📥 Commits

Reviewing files that changed from the base of the PR and between 37a2f4f and aa93e67.

📒 Files selected for processing (2)
  • .bash_aliases
  • tmux_session_picker.sh

Walkthrough

Fixed GitHub Actions workflow YAML structure, added pre-commit exclusion for docker_aliases.sh to prevent formatting issues, and added shellcheck disable comments to allow intentional word splitting in shell function wrappers.

Changes

Cohort / File(s) Summary
GitHub Workflow & CI Configuration
.github/workflows/shellcheck.yml, .pre-commit-config.yaml
Fixed invalid YAML structure in shellcheck workflow by replacing malformed line with proper jobs: key. Added exclude rule to prevent shfmt from processing docker_aliases.sh due to shell syntax incompatibility.
Shell Script Annotations
docker_aliases.sh
Added shellcheck disable comments (SC2086) to five Dozzle group command wrappers (grpdown, grupup, grplogs, grpps, grprestart) to suppress word-splitting warnings for intentional parameter expansion.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically identifies the three main fixes: repairing a corrupt shellcheck.yml and addressing docker_aliases.sh issues, directly matching the changeset.
Description check ✅ Passed The description covers all required sections with clear summaries, affected scripts identified, and a test plan included; however, most checklist items are unchecked despite claims of local verification.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/corrupt-shellcheck-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 19, 2026
- Remove $ from array index arithmetic (SC2004: unnecessary on arithmetic vars)
- Apply shfmt --indent 2 --case-indent --binary-next-line formatting
…s from servers

- Rename gh → grephist (gh conflicts with GitHub CLI)
- Add --color=auto --group-directories-first to ll/la/l aliases
- Add dockerclean, docker-rmi-untagged, dockerstopall from server versions
- Add chmod002 utility alias
- SC2142 disable for docker-rmi-untagged (awk $3 not a shell positional param)
- Drop server-specific dc alias path (/opt/dockergit/...)
@bakerboy448 bakerboy448 merged commit ec54af9 into main Apr 19, 2026
3 checks passed
@bakerboy448 bakerboy448 deleted the fix/corrupt-shellcheck-workflow branch April 19, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant