Skip to content

Make code python3 compatible without running 2to3#47

Merged
bakwc merged 4 commits intobakwc:masterfrom
CyberDem0n:py2py3compat
Dec 4, 2016
Merged

Make code python3 compatible without running 2to3#47
bakwc merged 4 commits intobakwc:masterfrom
CyberDem0n:py2py3compat

Conversation

@CyberDem0n
Copy link
Contributor

It was not producing correct code anyway...

It was not producing correct code anyway...
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 88.7% when pulling f7e0db2 on CyberDem0n:py2py3compat into 33bee8f on bakwc:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 89.303% when pulling e951f27 on CyberDem0n:py2py3compat into 33bee8f on bakwc:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 89.303% when pulling e951f27 on CyberDem0n:py2py3compat into 33bee8f on bakwc:master.

@bakwc
Copy link
Owner

bakwc commented Dec 4, 2016

Thanks, great job! You are using range everywhere, may be it would be better to use xrange? There can be a performance issue when using range in python2.
Also coverage is crashing when running at travis python3.4 - I suggest to run test without coverage for python3.4.

@coveralls
Copy link

coveralls commented Dec 4, 2016

Coverage Status

Coverage decreased (-0.06%) to 89.303% when pulling e663fe0 on CyberDem0n:py2py3compat into 33bee8f on bakwc:master.

@CyberDem0n
Copy link
Contributor Author

You are using range everywhere, may be it would be better to use xrange? There can be a performance issue when using range in python2.

It's not everywhere, but only in benchmarks. I don't think that you will see a big difference on small numbers. In all critical parts xrange is used (and iteritems for py2 instead of items).

Also coverage is crashing when running at travis python3.4 - I suggest to run test without coverage for python3.4.

Sometimes it builds on travis are crashing without any visible reason and triggering build job solves it...
I did one more commit, if it wont help I will remove coverage for py34.

@CyberDem0n
Copy link
Contributor Author

Funny, this time it crashed with python3.5

Somehow python 3.4 and 3.5 are failing randomly with core-dump...
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 88.645% when pulling 646b83c on CyberDem0n:py2py3compat into 33bee8f on bakwc:master.

@bakwc bakwc merged commit 7688384 into bakwc:master Dec 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants