Skip to content

Use rsplit instead of split#56

Merged
bakwc merged 1 commit intomasterfrom
rsplit
Jan 12, 2017
Merged

Use rsplit instead of split#56
bakwc merged 1 commit intomasterfrom
rsplit

Conversation

@bakwc
Copy link
Copy Markdown
Owner

@bakwc bakwc commented Jan 12, 2017

This is required for ipv6 hosts

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.09%) to 88.525% when pulling 55999cb on rsplit into b3389a2 on master.

@bakwc bakwc merged commit 35c6eea into master Jan 12, 2017
@bakwc bakwc deleted the rsplit branch January 12, 2017 22:42
@CyberDem0n
Copy link
Copy Markdown
Contributor

I guess this PR was made to support ipv6 addresses, but it's not enough, because in the dns resolver code you are using socket.gethostbyname_ex function, which supports only ipv4.
socket.getaddrinfo supports both

@bakwc
Copy link
Copy Markdown
Owner Author

bakwc commented Jan 13, 2017

Thanks, I'll fix that one too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants