-
Notifications
You must be signed in to change notification settings - Fork 28
Closed
Description
We often do long running MySql migrations using Percona's pt-online-schema-change tool.
For example, when adding a new nullable column, Percona first creates a temporary table, adds the new column, and copies over all the data with triggers to keep the original and new copy in sync. It then renames the temporary table to the original table name, and the original to an _old, which is then dropped.
Doing this on a database that was being replicated to ClickHouse revealed these two issues:
- alter table checks if the table name matches the config, but does so before stripping off the back ticks with
strip_sql_name. Since I didn't have a wildcard in my config, it just skipped theALTER TABLEcompletely. RENAME TABLEisn't supported yet.
I'll open a PR to fix these
Metadata
Metadata
Assignees
Labels
No labels