Fix percona migration #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakwc
requested changes
Jan 6, 2025
mysql_ch_replicator/db_replicator.py
Outdated
| if self.config.debug_log_level: | ||
| logger.debug(f'processing query event: {event.transaction_id}, query: {event.records}') | ||
| query = strip_sql_comments(event.records) | ||
| self.upload_records() |
Owner
There was a problem hiding this comment.
This is too broad, it will be triggered even on unhandled event types. I propose to upload records only if one of ifs happend (line 480 - 487)
Contributor
Author
There was a problem hiding this comment.
Ah, yes you're right of course. :-) I changed it to upload for alter/delete/rename.
Owner
|
Awesome! Thanks for the PR. Left one comment to address. |
jaredmdobson
pushed a commit
to ReMatter/mysql_ch_replicator
that referenced
this pull request
Nov 5, 2025
* Add unittest for "IF (NOT) EXISTS" * Support Percona-style migration to add a column * Review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77
Added
handle_rename_table_query()indb_replicator.pyto handleRENAME TABLEqueries, possibly renaming multiple tables at once.Refactored the code to split a table specifier in database and table name, map database name to target database when necessary, and check if the database and table match the config filter to a separate function since it was already duplicated for alter and delete queries, and the same code was necessary for table renames. Added advantage is that all places where it's used should now correctly strip the backticks, and check if the db/table match the config filter.
Moved the call to
self.upload_records()fromhandle_alter_query()tohandle_query_event()since inserts should be flushed before table rename, and probably before a delete as well since otherwise a delayed insert/update may be targeting a table that doesn't exist anymore.Added a test, also for my previous PR