Merged
Conversation
johngrantuk
reviewed
Jan 20, 2026
...ies/createPool/createPoolV3/liquidityBootstrapping/createLiquidityBootstrappingFixedPrice.ts
Outdated
Show resolved
Hide resolved
johngrantuk
reviewed
Jan 20, 2026
src/entities/inputValidator/liquidityBootstrapping/inputValidatorLiquidityBootstrapping.ts
Show resolved
Hide resolved
johngrantuk
reviewed
Jan 20, 2026
src/entities/inputValidator/liquidityBootstrapping/inputValidatorLiquidityBootstrapping.ts
Show resolved
Hide resolved
johngrantuk
requested changes
Jan 20, 2026
Member
johngrantuk
left a comment
There was a problem hiding this comment.
A couple of queries to address and please add a ChangeSet for the release.
We recently updated CI to skip integration tests which have been quite flaky. I added some AI generated unit tests so we have a bit more CI coverage. Would be great if you could double check them to see if they make sense or if you have any suggestions to add more.
…wed (validator is used)
mkflow27
commented
Jan 21, 2026
| ]; | ||
|
|
||
| describe('CreatePoolLiquidityBootstrapping - FixedPrice Unit Tests', () => { | ||
| const createPool = new CreatePoolLiquidityBootstrapping(); |
Collaborator
Author
There was a problem hiding this comment.
I have replaced it with CreatePool here so that the below edge cases get passed through the inputValidator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Liquidity Bootstrapping Fixed Price Pool Support
Summary
Adds support for creating and initializing Fixed Price Liquidity Bootstrapping Pools (Fixed Price LBPs) in the SDK.
Changes
Core Features
PoolType.LiquidityBootstrappingFixedPriceenum valueCreatePoolLiquidityBootstrappingFixedPriceInputandFixedPriceLBPParamstypesFixedPriceLBPoolFactoryInputValidatorLiquidityBootstrappingFixedPriceKey Files
src/types.ts- Added new pool type enumsrc/entities/createPool/types.ts- Added fixed price LBP input typessrc/entities/createPool/createPoolV3/liquidityBootstrapping/createLiquidityBootstrapping.ts- Added fixed price encoding logicsrc/entities/inputValidator/liquidityBootstrapping/inputValidatorLiquidityBootstrappingFixedPrice.ts- New validator classsrc/entities/inputValidator/inputValidator.ts- Registered new validatorsrc/entities/createPool/createPoolV3/index.ts- Registered pool typetest/lib/utils/createPoolHelper.ts- Added ABI mapping for event decodingtest/v3/createPool/liquidityBootstrapping/liquidityBootstrappingFixedPrice.integration.test.ts- Integration testsValidation Rules
Testing