fix wrong vdevice reference bug for setups/scenarios with inheritance#112
Merged
matosys merged 4 commits intobalder-dev:mainfrom Feb 14, 2025
Merged
Conversation
…ectly_overwrite_and_add_feature_without_redefining.py`
…overwrite_and_add_feature_without_redefining.py`
… make sure that shared instances of parent device classes are handled correctly bug fix for collecting error for setups/scenarios with shared parent device classes (with VDevice reference) while the feature is instantiated in parent class
…objects()` instead of `get_original_instanced_feature_objects()` for getting all instantiated features
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that occurs in inheritance environments of scenarios or setups. As soon as the parent scenario/setup class has a vdevice mapping and its children (at least two active subclasses) didn't overwrite the vdevice reference, one fix reference is established during the whole session (same feature instance for subclasses). This behavior is wrong, because it results in discarded variations for all other setups/scenarios than the first one.